Closed Bug 1415057 Opened 3 years ago Closed 3 years ago
Linux 32 L10N repack failures on beta release builds
https://archive.mozilla.org/pub/thunderbird/candidates/57.0b1-candidates/build1/logs/release-comm-beta-linux_repack_1-bm77-build1-build5.txt.gz We disabled configuring stylo in https://hg.mozilla.org/comm-central/rev/5cdc0ea5bca1 for l10n-repacks. But now that stylo is enabled by default, that way disabling stylo no longer works. A better way of handling things might be to add back --disable-compile-environment which was disabled in Bug 1311045
Before making changes to disable-compile-environment, please read bug 1345422 comment #57 and bug 1345422 comment #58. There appears to be some evidence that with disable-compile-environment in place, things start failing on Linux. Maybe it would be different in today's environment. There has been a long history of adding and removing that option on the various platforms.
firefox has add `build/mozconfig.no-compile` that handles passing that argument, and unsetting a bunch of variables that will cause errors like the ones that have been seen with --disable-compile-environment in the past. (Added in Bug 1373150)
Pushed by email@example.com: https://hg.mozilla.org/comm-central/rev/88393c26b421 Disable compiler environment on L10N repacks; r=me
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
In an excess of caution, only touch the platform that is failing, for the current beta. Jorg, I've pushed the version that touches all the platforms to C-C. If the L10N nightlies build with that, this patch can be uplifted to c-b for 57.
Assignee: nobody → mozilla
Attachment #8926098 - Flags: review+
OK, so will to trigger a Daily/Nightly now or wait for tomorrow's?
Flags: needinfo?(jorgk) → needinfo?(mozilla)
The nightly builds look good, so https://bugzilla.mozilla.org/attachment.cgi?id=8926098&action=edit can be landed on comm-beta.
Flags: needinfo?(mozilla) → needinfo?(jorgk)
Beta (TB 57): https://hg.mozilla.org/releases/comm-beta/rev/caffea3f41f87014608c38c4c408af56b9a865a1
You need to log in before you can comment on or make changes to this bug.