Closed Bug 1415070 Opened 2 years ago Closed 2 years ago

The window buttons are hidden on Windows 7

Categories

(Core :: Graphics: WebRender, enhancement, P1)

All
Windows 7
enhancement

Tracking

()

RESOLVED FIXED
mozilla58
Tracking Status
firefox57 --- unaffected
firefox58 --- unaffected

People

(Reporter: mstange, Assigned: mstange)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [wr-reserve])

Attachments

(1 file)

We're not cutting out the window buttons shape with WebRender. This means that you can't see the buttons or might accidentally close your window on Windows 7.
This patch is completely untested.
Whiteboard: [wr-mvp] [triage]
Priority: -- → P1
Whiteboard: [wr-mvp] [triage] → [wr-mvp]
Assignee: nobody → mstange
Status: NEW → ASSIGNED
Whiteboard: [wr-mvp] → [wr-reserve]
It builds on try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=4c857fa275f0&selectedJob=143403947

I've tested it on a  Windows 7 machine in the office and it works.
Attachment #8925805 - Flags: review?(bugmail)
Comment on attachment 8925805 [details]
Bug 1415070 - Cut out the window button shape on Windows 7.

https://reviewboard.mozilla.org/r/196986/#review203472

::: widget/windows/nsWindow.cpp:4097
(Diff revision 3)
> +  if (mWindowButtonsRect) {
> +    wr::LayoutRect rect = wr::ToLayoutRect(*mWindowButtonsRect);
> +    nsTArray<wr::ComplexClipRegion> roundedClip;
> +    roundedClip.AppendElement(wr::ToComplexClipRegion(
> +      RoundedRect(ThebesRect(mWindowButtonsRect->ToUnknownRect()),
> +                  RectCornerRadii(0, 0, 3, 3))));

Is the bottom-radius here supposed to correspond to the clearRegion stuff below where you set mWindowButtonsRect? That clearRegion doesn't seem to be a symmetrical thing, it looks like the bottom-left corner has more clipped out than the bottom-right.
Attachment #8925805 - Flags: review?(bugmail) → review+
Hmm, you're right. That code clears out a shape that looks like this:

###############
###############
###############
_##############
__############_

And that seems to be because the rest of the curve extends into the right edge of the window frame, which is not part of the our rendering area.

I'm going to extend the window buttons rect by 1px on the right side in order to match what's actually happening.
Pushed by mstange@themasta.com:
https://hg.mozilla.org/integration/autoland/rev/a4632a2f8aee
Cut out the window button shape on Windows 7. r=kats
Filed bug 1416011 about the failure. Once that lands, this can land again.
Depends on: 1416011
Flags: needinfo?(mstange)
Pushed by mstange@themasta.com:
https://hg.mozilla.org/integration/autoland/rev/e9a687531a09
Cut out the window button shape on Windows 7. r=kats
https://hg.mozilla.org/mozilla-central/rev/e9a687531a09
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
Blocks: 1594302
You need to log in before you can comment on or make changes to this bug.