Closed Bug 1415082 Opened 3 years ago Closed 3 years ago

TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\pref-window\test-font-chooser.js | test-font-chooser.js::test_font_name_not_present

Categories

(Thunderbird :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 58.0

People

(Reporter: jorgk-bmo, Assigned: aceman)

Details

(Keywords: intermittent-failure, Whiteboard: [Thunderbird-testfailure: Z Win only])

Attachments

(1 file)

TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\pref-window\test-font-chooser.js | test-font-chooser.js::test_font_name_not_present

First seen Wed Nov 1, 2017, 23:41:23
https://treeherder.mozilla.org/#/jobs?repo=comm-central&revision=bb96540a652557271e302ae468c18689b6c5d811&selectedJob=141508161

Log says:
INFO -  SUMMARY-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\pref-window\test-font-chooser.js | test-font-chooser.js::test_font_name_not_present
INFO -    EXCEPTION: The display pane font should be Arial, but nothing is actually selected.
INFO -      at: test-font-chooser.js line 56
INFO -         assert_fonts_equal test-font-chooser.js:56 11
INFO -         verify_display_pane test-font-chooser.js:73 5

Seems to be pretty intermittent. I'll rerun Mozmill on the latest push to confirm and I'll report the result in the next comment.
Flags: needinfo?(acelists)
(In reply to Jorg K (:jorgk, GMT+1) from comment #0)
> Seems to be pretty intermittent.
Looks like I was wrong that it's pretty perma-red now.
mozmake SOLO_TEST=pref-window/test-font-chooser.js mozmill-one
passed locally, but I can see that it takes a while before the menu items for the fonts are filled in.

So we probably need to wait some more somewhere.
Attached patch 1415082.patchSplinter Review
Potential fix (I can't test it locally, seems Windows only).
Try run green:
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=c0efa253c7a84abdb6008a20e187c58be2d19a53
Previous run without the patch has Window opt green but Windows debug with the failure.
Flags: needinfo?(acelists)
Attachment #8926270 - Flags: review?(jorgk)
Comment on attachment 8926270 [details] [diff] [review]
1415082.patch

(In reply to :aceman from comment #3)
> Potential fix (I can't test it locally, seems Windows only).
Sadly this is now perma-red on Mac as well.

I've run it locally and it doesn't do harm, so let's go with this, what have we got to lose ;-(

Thanks for the quick action, BTW.
Attachment #8926270 - Flags: review?(jorgk) → review+
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/296efe53253a
wait for population of fonts in the preferences dialog. r=jorgk
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Fingers crossed ;-)
Target Milestone: --- → Thunderbird 58.0
Looking very good on Windows and Mac, thanks again!!
Assignee: nobody → acelists
You need to log in before you can comment on or make changes to this bug.