Closed Bug 1415103 Opened 3 years ago Closed 3 years ago

Remove dead code in crash reporting

Categories

(Toolkit :: Crash Reporting, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla58
Tracking Status
firefox58 --- fixed

People

(Reporter: cyu, Assigned: cyu)

Details

Attachments

(1 file, 1 obsolete file)

headlessClient in nsExceptionHandler.cpp is no longer used: it't not set to true any more in the file, and the relevant if() blocks are unconditional. Similarly, lastRunCrashId is declared in nsIXULRuntime.idl, but no one is reading it from JS or C++. They are dead code and we are safe to remove them.
Assignee: nobody → cyu
Attachment #8925855 - Flags: review?(gsvelto)
Update: also remove crashMarkerFileName in nsExceptionHandler.cpp.
Attachment #8925855 - Attachment is obsolete: true
Attachment #8925855 - Flags: review?(gsvelto)
Attachment #8925878 - Flags: review?(gsvelto)
Comment on attachment 8925855 [details] [diff] [review]
Remove dead code in crash reporting

Good stuff, thanks for catching this. The crash reporter code is finally getting cleaner, I'm really happy of this kind of progress.
Attachment #8925855 - Flags: review+
Comment on attachment 8925878 [details] [diff] [review]
Remove dead code in crash reporting

Even better now :)
Attachment #8925878 - Flags: review?(gsvelto) → review+
Status: NEW → ASSIGNED
https://hg.mozilla.org/mozilla-central/rev/13ec107f2119
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in before you can comment on or make changes to this bug.