Closed Bug 1415103 Opened 4 years ago Closed 4 years ago
Remove dead code in crash reporting
headlessClient in nsExceptionHandler.cpp is no longer used: it't not set to true any more in the file, and the relevant if() blocks are unconditional. Similarly, lastRunCrashId is declared in nsIXULRuntime.idl, but no one is reading it from JS or C++. They are dead code and we are safe to remove them.
Assignee: nobody → cyu
Attachment #8925855 - Flags: review?(gsvelto)
Update: also remove crashMarkerFileName in nsExceptionHandler.cpp.
Comment on attachment 8925855 [details] [diff] [review] Remove dead code in crash reporting Good stuff, thanks for catching this. The crash reporter code is finally getting cleaner, I'm really happy of this kind of progress.
Attachment #8925855 - Flags: review+
Comment on attachment 8925878 [details] [diff] [review] Remove dead code in crash reporting Even better now :)
Attachment #8925878 - Flags: review?(gsvelto) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/13ec107f211922aec40d4993eef12690c54a0c36 Bug 1415103 - Remove dead code in crash reporting. r=gsvelto
You need to log in before you can comment on or make changes to this bug.