Remove dead code in crash reporting

RESOLVED FIXED in Firefox 58

Status

()

enhancement
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: cyu, Assigned: cyu)

Tracking

Trunk
mozilla58
Points:
---

Firefox Tracking Flags

(firefox58 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

headlessClient in nsExceptionHandler.cpp is no longer used: it't not set to true any more in the file, and the relevant if() blocks are unconditional. Similarly, lastRunCrashId is declared in nsIXULRuntime.idl, but no one is reading it from JS or C++. They are dead code and we are safe to remove them.
Assignee: nobody → cyu
Attachment #8925855 - Flags: review?(gsvelto)
Update: also remove crashMarkerFileName in nsExceptionHandler.cpp.
Attachment #8925855 - Attachment is obsolete: true
Attachment #8925855 - Flags: review?(gsvelto)
Attachment #8925878 - Flags: review?(gsvelto)
Comment on attachment 8925855 [details] [diff] [review]
Remove dead code in crash reporting

Good stuff, thanks for catching this. The crash reporter code is finally getting cleaner, I'm really happy of this kind of progress.
Attachment #8925855 - Flags: review+
Comment on attachment 8925878 [details] [diff] [review]
Remove dead code in crash reporting

Even better now :)
Attachment #8925878 - Flags: review?(gsvelto) → review+
Status: NEW → ASSIGNED

Comment 6

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/13ec107f2119
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in before you can comment on or make changes to this bug.