Open Bug 1415117 Opened 4 years ago Updated 4 years ago

SessionRestore does not update tab title if language changes on restart

Categories

(Core :: Internationalization, defect, P5)

58 Branch
defect

Tracking

()

Tracking Status
firefox56 --- unaffected
firefox57 --- unaffected
firefox58 --- affected
firefox59 --- affected

People

(Reporter: cbadescu, Unassigned)

References

Details

Attachments

(3 files)

2.40 MB, image/gif
Details
6.62 MB, application/x-zip-compressed
Details
1.50 MB, application/x-zip-compressed
Details
Attached image Translate.gif
[Affected versions]:
- Firefox 58.0a1 (2017-11-06)

[Affected platforms]:
- Windows 7 64-bit
- Mac OS X 10.13

[Prerequisites]
Set intl.locale.matchOS = False
Set general.useragent.locale = hi-IN

[Steps to reproduce]:
1.On a new profile open about:addons and some about:newtab pages.
2.Install the following language pack:
https://ftp.mozilla.org/pub/firefox/nightly/latest-mozilla-central-l10n/win64/xpi/firefox-58.0a1.hi-IN.langpack.xpi
3.Restart the browser.
4.Open some new tabs.
5.Observe the new opened tabs and the ones before the restart.

[Expected results]:
- The tabs opened before the restart are translated.

[Actual results]:
- After the step 3, you can see that the name of the new tab has changed from “New Tab” to “about:newtab”.
- The tabs opened before the restart are not translated.

Please see the attached video
Cosmin, can you do the same test process by starting a different fully localized build on the same profile? I'd love to see how much of this is session restore and crossing language boundaries, and how much of this is language packs.

Also, it'd be good to see the same experiment run on 56 with legacy-language packs to contrast with webext language packs.
Attached file Builds.zip
Of course Axel, here are the results:

Firefox 56.0.2 (20171024165158) under Wind 7 64-bit - it and en-US - with the legacy add-ons, the opened “New Tab” before the restart it is translated after you select it.

Firefox 58.0a1 (20171106100122) under Wind 7 64-bit - it - the behavior is the same as presented in the bug.

Please see the attached videos.
Thank you for the report CosminB.

I'll investigate your report today.
Flags: needinfo?(gandalf)
Hi CosminB,

I tried to reproduce it using today's Firefox Nightly and a langpack for it, and was unable to.

Can you please try today's Firefox Nightly with a nightly language pack for it from https://ftp.mozilla.org/pub/firefox/nightly/latest-mozilla-central-l10n/win64/xpi/ ?

Thank you!
Flags: needinfo?(gandalf) → needinfo?(cosmin.badescu)
Attached file Bug1415117.zip
Sorry for the delayed response, I was on PTO.

Yes, the issue is still there, I updated the bug.

I was able to reproduce this issue on Firefox 59.0a1 (20171203220339) and Firefox 58.0b8 (20171130160223) under Win 7 64-bit.

Nightly:
https://ftp.mozilla.org/pub/firefox/nightly/latest-mozilla-central-l10n/win64/xpi/firefox-59.0a1.it.langpack.xpi

Beta:
https://ftp.mozilla.org/pub/firefox/nightly/latest-mozilla-beta-l10n/win64/xpi/firefox-58.0.it.langpack.xpi 

Please have a look at the attached videos
Flags: needinfo?(cosmin.badescu)
Ahh, ok, I tried again and this time I was able to reproduce it. Thanks for reporting it!

The reason for this bug is a bit more rooted in SessionRestore really - it just loads the tab title from the previous session and doesn't update it until you click on the tab (which triggers loading).

I'm not sure if we can really fix it easily, because in most cases the tab title for about:addons etc. does come from within the document, not from Firefox UI.
That means that the only way to learn that the title is new is to load the tab, which we don't do until selected.

I'm going to keep the bug open, in case we find a better solution, but also P5 because it's really an edge case between session restore and localization.
Priority: -- → P5
Summary: Tabs are not translated if are opened before the restart of the browser → SessionRestore does not update tab title if language changes on restart
You need to log in before you can comment on or make changes to this bug.