1415154 - Port |Bug 1414767 - Moving SlicedInputStream under mozilla namespace|

Status: RESOLVED FIXED

(MailNews Core :: Backend, defect)

Description

[Jorg K (CEST = GMT+2)]

+#include "mozilla/SlicedInputStream.h"
-#include "SlicedInputStream.h"

Comment 1

[Jorg K (CEST = GMT+2)]

Attachment: 1415154-SlicedInputStream-mozilla.patch (v1)

Maybe I'll have to prepend mozilla:: in some spots, let's see what the compiler says.

Comment 2

[Jorg K (CEST = GMT+2)]

Attachment: 1415154-SlicedInputStream-mozilla.patch

Three of the four files had
  using namespace mozilla;
so I added it to the fourth one instead of adding mozilla:: in many places.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/f840d467eaa1
Port bug 1414767 to mailnews: SlicedInputStream moved to mozilla namespace. rs=bustage-fix

Comment 4

[:aceman]

Comment on attachment 8925923 [details] [diff] [review]
1415154-SlicedInputStream-mozilla.patch

Review of attachment 8925923 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks.

::: mailnews/local/src/nsMailboxProtocol.cpp
@@ +22,5 @@
>  #include "prerror.h"
>  #include "prprf.h"
>  #include "nspr.h"
>  
>  static mozilla::LazyLogModule MAILBOX("MAILBOX");

I wonder if this prefix could be removed now, but don't bother PL.

::: mailnews/news/src/nsNNTPProtocol.cpp
@@ +23,4 @@
>  #include "nsINntpUrl.h"
>  #include "prmem.h"
>  #include "prtime.h"
>  #include "mozilla/Logging.h"

Maybe this one could be moved to the others, but don't bother to do it now PL.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/8fe22762188b
Follow-up: minor tweaks (order of includes, etc.). r=aceman DONTBUILD

Comment 6

[Jorg K (CEST = GMT+2)]

Let's make it better. Sadly perfect isn't possible here since the include order is messed up in most places and follows some weird rules.