Build doesn't use gradle by default

RESOLVED FIXED in Firefox 58

Status

enhancement
RESOLVED FIXED
2 years ago
Last month

People

(Reporter: droeh, Assigned: nalexander)

Tracking

unspecified
mozilla58
All
Android

Firefox Tracking Flags

(firefox58 fixed)

Details

Attachments

(1 attachment)

According to [0], local builds should be using gradle by default, but that doesn't appear to be the case. After hitting a situation where Try was failing to build something that built successfully locally, I added 'ac_add_options --with-gradle' to my mozconfig and only then did my build actually download and use gradle (and fail similarly to the Try build).

[0]: https://mail.mozilla.org/pipermail/mobile-firefox-dev/2017-November/002360.html
(In reply to Dylan Roeh (:droeh) from comment #0)
> According to [0], local builds should be using gradle by default, but that
> doesn't appear to be the case. After hitting a situation where Try was
> failing to build something that built successfully locally, I added
> 'ac_add_options --with-gradle' to my mozconfig and only then did my build
> actually download and use gradle (and fail similarly to the Try build).
> 
> [0]:
> https://mail.mozilla.org/pipermail/mobile-firefox-dev/2017-November/002360.
> html

droeh: you're totally correct -- thanks for filing.  I realized this when I woke up this morning and thought... damn, that's an embarrassing email to write.  Glad --with-gradle worked for you :)
Assignee: nobody → nalexander
Status: NEW → ASSIGNED
Comment on attachment 8926008 [details]
Bug 1415220 - Make Fennec build --with-gradle by default.

https://reviewboard.mozilla.org/r/197246/#review202384
Attachment #8926008 - Flags: review+
Pushed by nalexander@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2d6de6f3bb5c
Make Fennec build --with-gradle by default. r=sebastian
https://hg.mozilla.org/mozilla-central/rev/2d6de6f3bb5c
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
Comment on attachment 8926008 [details]
Bug 1415220 - Make Fennec build --with-gradle by default.

https://reviewboard.mozilla.org/r/197246/#review202720
Attachment #8926008 - Flags: review?(max) → review+
Product: Firefox for Android → Firefox Build System
Target Milestone: Firefox 58 → mozilla58
You need to log in before you can comment on or make changes to this bug.