Closed Bug 1415234 Opened 2 years ago Closed 2 years ago

Stand up a simple WebIDL getter with a MOZ_CAN_RUN_SCRIPT annotation

Categories

(Core :: DOM: Core & HTML, enhancement, P2)

53 Branch
enhancement

Tracking

()

RESOLVED FIXED
mozilla59
Tracking Status
firefox59 --- fixed

People

(Reporter: bzbarsky, Assigned: bzbarsky)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Mostly codegen changes.  I'm going to start with HTMLInputElement::Width, which calls nsGenericHTMLElement::GetWidthHeightForImage, which does GetPrimaryFrame(FlushType::Layout).

In an ideal world, of course, we would have the annotation further along in that callchain; that will be done in followups.
Priority: -- → P2
This basically marks most of the bindings bits as MOZ_CAN_RUN_SCRIPT.

MozReview-Commit-ID: BgRhDh0X7Yz
Attachment #8926693 - Flags: review?(nika)
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
Attachment #8926693 - Flags: review?(nika) → review+
Pushed by bzbarsky@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9ef61399999e
Annotate HTMLInputElement::Width() as MOZ_CAN_RUN_SCRIPT and plumb through the binding bits needed to make this pass static analysis.  r=mystor
https://hg.mozilla.org/mozilla-central/rev/9ef61399999e
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.