1415288 - No builds in firefox_primary_builds for 58.0b1 which is in firefox_versions.json in product-details

Status: RESOLVED FIXED

(Release Engineering :: Applications: Shipit, defect)

Description

[Paul [:pmac] McLanahan]

Our builds of the product-details data[0] are failing, and thus are not updating on www.mozilla.org, due to there being no builds for 58.0b1 in:

https://product-details.mozilla.org/1.0/firefox_primary_builds.json

While it is listed as the version for FIREFOX_DEVEDITION in:

https://product-details.mozilla.org/1.0/firefox_versions.json

To fix it we just need build info for 58.0b1 in firefox_primary_builds.json.

[0] https://ci.us-west.moz.works/blue/organizations/jenkins/product-details-json-watch/activity

Comment 1

[Jordan Lund (:jlund)]

nthomas, our bouncer product-details expert, could you have a look at this or walk me through the why and the how when you get a chance today?

I'm wondering if this is the result of 58.0b1 devedition getting shipped while beta is still on 57 cycle. And if so, if it is safe to update firefox_primary_builds.json.

I also want to sanity check this isn't the result of a mistake from having to: https://bugzilla.mozilla.org/show_bug.cgi?id=1413700#c1

Comment 2

[Rail Aliiev [:rail]]

https://github.com/mozilla-releng/ship-it/blob/5b95541df769f2790e2865ebaa538b0b51a368ef/kickoff/jsonexport.py#L255 is what generates that file and it doesn't use devedition: https://github.com/mozilla-releng/ship-it/blob/5b95541df769f2790e2865ebaa538b0b51a368ef/kickoff/jsonexport.py#L220

Comment 3

[Nick Thomas [:nthomas] (UTC+12)]

Rail is our expert here, but I'll take a stab at fixing this up.

Comment 4

[Nick Thomas [:nthomas] (UTC+12)]

https://github.com/mozilla-releng/ship-it/pull/202

Comment 5

[Nick Thomas [:nthomas] (UTC+12)]

Sent email about deploy during change-freeze; will deploy in ~24 hours if no objections raised.

Comment 6

[Paul [:pmac] McLanahan]

To avoid risk it was decided that the change should not be deployed yet, but that FIREFOX_DEVEDITION should be set back to match LATEST_FIREFOX_DEVEL_VERSION at 57.0b14. This has cleared up the issue of product-details updates not updating for www.mozilla.org. Since the root cause is still not addressed I think this bug should stay open to track the work from the PR in comment #4. Thanks for all the help!

Comment 7

[Nick Thomas [:nthomas] (UTC+12)]

Self-ni to land this after the change freeze lifts (on or before Nov 28).

Comment 8

[Nick Thomas [:nthomas] (UTC+12)]

Johan deployed this today, thank you sir.

I've marked DevEd 58.0b1 & b2 as shipped again in ship-it, and checked https://github.com/mozilla/releasewarrior/tree/master/releases/FUTURE doesn't have any notes about special casing future b1 and b2.