Closed
Bug 1415298
Opened 7 years ago
Closed 7 years ago
Android-Gradle plugin 2.3+ broke |mach android test| locally
Categories
(Firefox Build System :: Android Studio and Gradle Integration, enhancement)
Firefox Build System
Android Studio and Gradle Integration
Tracking
(firefox58 fixed)
RESOLVED
FIXED
mozilla58
| Tracking | Status | |
|---|---|---|
| firefox58 | --- | fixed |
People
(Reporter: nalexander, Assigned: nalexander)
References
Details
Attachments
(2 files)
Bug 1366644 updated the Android-Gradle plugin, which no longer does certain steps in the right order for our unit tests (|mach android test|). That means we see https://github.com/robolectric/robolectric/issues/2647, at least locally. We don't see it in production because we only ever run our unit tests _after_ a complete build, which does the steps in the right order (by accident). It's easy to address this.
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
Assignee | |
Updated•7 years ago
|
Summary: Android-Gradle plugin 3.0+ broke |mach android test| locally → Android-Gradle plugin 2.3+ broke |mach android test| locally
|
||
Comment 3•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8926062 [details] Bug 1415298 - Fix finding assets/ in |mach android test| locally. https://reviewboard.mozilla.org/r/197296/#review202718
Attachment #8926062 -
Flags: review?(max) → review+
|
|
||
Comment 4•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8926061 [details] Bug 1415298 - Pre: Move assets/ into standard Gradle location. https://reviewboard.mozilla.org/r/197294/#review202722
Attachment #8926061 -
Flags: review?(max) → review+
Pushed by nalexander@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/160586d66bcb Pre: Move assets/ into standard Gradle location. r=maliu https://hg.mozilla.org/integration/autoland/rev/e046373e0dca Fix finding assets/ in |mach android test| locally. r=maliu
|
||
Comment 6•7 years ago
|
||
Backed out for orphaned pattern 'assets/**' in mobile/android/app/moz.build: https://hg.mozilla.org/integration/autoland/rev/a2bf3b8c08ea588d1ab6b23b41ca665a4cf305a0 Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=143088676&repo=autoland [task 2017-11-08T17:53:56.743Z] 17:53:56 INFO - E AssertionError: The pattern 'assets/**' in a Files() entry in '/builds/worker/workspace/build/src/mobile/android/app/moz.build' corresponds to no files in the tree. [task 2017-11-08T17:53:56.743Z] 17:53:56 INFO - E Please update this entry.
Flags: needinfo?(nalexander)
Blocks: 1414995
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
Pushed by nalexander@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/833349e8b275 Pre: Move assets/ into standard Gradle location. r=maliu https://hg.mozilla.org/integration/autoland/rev/4ec159789617 Fix finding assets/ in |mach android test| locally. r=maliu
|
|
||
Comment 10•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/833349e8b275 https://hg.mozilla.org/mozilla-central/rev/4ec159789617
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox58:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
|
||
Comment 11•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8926061 [details] Bug 1415298 - Pre: Move assets/ into standard Gradle location. https://reviewboard.mozilla.org/r/197294/#review203550
Attachment #8926061 -
Flags: review?(cnevinchen) → review+
|
|
||
Comment 12•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8926062 [details] Bug 1415298 - Fix finding assets/ in |mach android test| locally. https://reviewboard.mozilla.org/r/197296/#review203552
Attachment #8926062 -
Flags: review?(cnevinchen) → review+
|
|
Assignee | |
Updated•7 years ago
|
Flags: needinfo?(nalexander)
|
||
Updated•5 years ago
|
Product: Firefox for Android → Firefox Build System
Target Milestone: Firefox 58 → mozilla58
You need to log in
before you can comment on or make changes to this bug.
Description
•