1415318 - Enable GeckoView to send console.log to logcat

Status: RESOLVED FIXED

(GeckoView :: General, enhancement, P2)

Description

[Randall Barker [:rbarker]]

Currently console.log messages are not visible in GeckoView. Enable sending them to the logcat.

Comment 1

[Randall Barker [:rbarker]]

Attachment: Bug 1415318 - Enable GeckoView to send console.log to logcat

Review commit: https://reviewboard.mozilla.org/r/197324/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/197324/

Comment 2

[James Willcox (:snorp) ([e-mail]) (he/him)]

Comment on attachment 8926097 [details]
Bug 1415318 - Enable GeckoView to send console.log to logcat

https://reviewboard.mozilla.org/r/197324/#review219726

I think we should make this an opt-in feature from the app -- capturing console output can be a performance burden.

Comment 3

[James Willcox (:snorp) ([e-mail]) (he/him)]

Attachment: Bug 1415318 - Optionally send web console output to logcat in GeckoView

Review commit: https://reviewboard.mozilla.org/r/250472/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/250472/

Comment 4

[James Willcox (:snorp) ([e-mail]) (he/him)]

(In reply to James Willcox (:snorp) ([e-mail]) from comment #2)
> Comment on attachment 8926097 [details]
> Bug 1415318 - Enable GeckoView to send console.log to logcat
> 
> https://reviewboard.mozilla.org/r/197324/#review219726
> 
> I think we should make this an opt-in feature from the app -- capturing
> console output can be a performance burden.

I had changed my mind about this, but Randall reminded me that this might be easy via a GeckoRuntimeSetting, so I'll revise the patch to use that.

Comment 5

[James Willcox (:snorp) ([e-mail]) (he/him)]

Comment on attachment 8984603 [details]
Bug 1415318 - Optionally send web console output to logcat in GeckoView

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/250472/diff/1-2/

Comment 6

[Randall Barker [:rbarker]]

Comment on attachment 8984603 [details]
Bug 1415318 - Optionally send web console output to logcat in GeckoView

https://reviewboard.mozilla.org/r/250472/#review256854

Comment 7

[(inactive) Jim Chen [:jchen] [:darchons]]

Comment on attachment 8984603 [details]
Bug 1415318 - Optionally send web console output to logcat in GeckoView

https://reviewboard.mozilla.org/r/250472/#review256932

::: mobile/android/geckoview/src/main/java/org/mozilla/geckoview/GeckoRuntimeSettings.java:284
(Diff revision 2)
>      /* package */ Pref<Integer> mCookieLifetimeDays = new Pref<Integer>(
>          "network.cookie.lifetime.days", 90);
>      /* package */ Pref<String> mTrackingProtection = new Pref<String>(
>          "urlclassifier.trackingTable", "");
> +    /* package */ Pref<Boolean> mConsoleOutput = new Pref<Boolean>(
> +            "geckoview.console.enabled", false);

Alignment

::: mobile/android/geckoview/src/main/java/org/mozilla/geckoview/GeckoRuntimeSettings.java:292
(Diff revision 2)
>      /* package */ boolean mJavaCrashReporting;
>      /* package */ boolean mDebugPause;
>  
>      private final Pref<?>[] mPrefs = new Pref<?>[] {
>          mCookieBehavior, mCookieLifetime, mCookieLifetimeDays, mJavaScript,
> -        mRemoteDebugging, mTrackingProtection, mWebFonts
> +        mRemoteDebugging, mTrackingProtection, mWebFonts, mConsoleOutput

Alphabetize

::: mobile/android/geckoview/src/main/java/org/mozilla/geckoview/GeckoRuntimeSettings.java:605
(Diff revision 2)
> +    /**
> +     * Get whether or not web console messages are sent to logcat.
> +     *
> +     * @return This GeckoRuntimeSettings instance.
> +     */
> +    public @NonNull boolean getConsoleOutputEnabled() {

`@NonNull` doesn't make sense here.

::: mobile/android/modules/geckoview/GeckoViewConsole.jsm:26
(Diff revision 2)
> +
> +  get enabled() {
> +    return this._isEnabled;
> +  },
> +
> +  set enabled(val) {

aVal

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8904c9386abf
Optionally send web console output to logcat in GeckoView r=jchen,rbarker

Comment 9

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/8904c9386abf

Comment 10

[Chris Peterson [:cpeterson]]

This is a debug feature. We don't need to uplift to Beta 62.