1415343 - FxAccountsWebChannel.jsm checks for possibly never available 'window' variable

Status: RESOLVED FIXED

(Firefox :: Firefox Accounts, defect)

Description

[Mark Banner (:standard8)]

I picked this up whilst starting to looking into better linting of jsms in bug 1369722.

http://searchfox.org/mozilla-central/rev/ed212c79cfe86357e9a5740082b9364e7f6e526f/services/fxaccounts/FxAccountsWebChannel.jsm#512-513

```
// If running in context of the browser chrome, window does not exist.
var targetWindow = typeof window === "undefined" ? null : window;
```

As far as I can see in the Firefox code, that would never be loaded in a non-chrome context. Is there somewhere outside of mozilla-central that it would be used, or can this line be dropped now?

Comment 1

[Mark Hammond [:markh] [:mhammond]]

I expect that's copy/pasta from about:accounts, so is safe to remove. Thanks!

Comment 2

[Mark Banner (:standard8)]

Attachment: Bug 1415343 - Remove useless check for target window from FxAccountsWebChannel.jsm.

Review commit: https://reviewboard.mozilla.org/r/198006/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/198006/

Comment 3

[Mark Hammond [:markh] [:mhammond]]

Comment on attachment 8926769 [details]
Bug 1415343 - Remove useless check for target window from FxAccountsWebChannel.jsm.

https://reviewboard.mozilla.org/r/198006/#review203296

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b7bf7d827279
Remove useless check for target window from FxAccountsWebChannel.jsm. r=markh

Comment 5

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/b7bf7d827279