1415365 - Make compare-mozconfigs platform agnostics

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement)

Description

[Gregory Szorc [:gps]]

compare-mozconfigs is doing some basic static analysis. But for what I can only imagine is hysterical raisins, it limits its execution to mozconfigs for the current target platform.

I see no reason why we can't run compare-mozconfigs for all platforms all the time.

Comment 1

[Gregory Szorc [:gps]]

Attachment: Bug 1415365 - Remove unused imports;

Review commit: https://reviewboard.mozilla.org/r/197420/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/197420/

Comment 2

[Gregory Szorc [:gps]]

Attachment: Bug 1415365 - Add whitelist entry for MOZ_UPDATE_CHANNEL testing;

This line was added to the nightly macosx64 mozconfig in 9312a1903bf4
(bug 1391643). But we didn't catch it because compare-mozconfigs
only analyzes the current platform and we cross compile for MacOS
from Linux.

Review commit: https://reviewboard.mozilla.org/r/197422/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/197422/

Comment 3

[Gregory Szorc [:gps]]

Attachment: Bug 1415365 - Run compare-mozconfigs for all platforms;

compare-mozconfigs is platform agnostic AFAICT. And it runs fast.
Let's run tests for all the platforms all the time.

Review commit: https://reviewboard.mozilla.org/r/197424/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/197424/

Comment 4

[Michael Shal [:mshal]]

Comment on attachment 8926172 [details]
Bug 1415365 - Remove unused imports;

https://reviewboard.mozilla.org/r/197420/#review202612

Comment 5

[Michael Shal [:mshal]]

Comment on attachment 8926173 [details]
Bug 1415365 - Add whitelist entry for MOZ_UPDATE_CHANNEL testing;

https://reviewboard.mozilla.org/r/197422/#review202614

Comment 6

[Michael Shal [:mshal]]

Comment on attachment 8926174 [details]
Bug 1415365 - Run compare-mozconfigs for all platforms;

https://reviewboard.mozilla.org/r/197424/#review202616

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b4a5ab45942f
Remove unused imports; r=mshal
https://hg.mozilla.org/integration/autoland/rev/3d7619511fe8
Add whitelist entry for MOZ_UPDATE_CHANNEL testing; r=mshal
https://hg.mozilla.org/integration/autoland/rev/457cdbb01def
Run compare-mozconfigs for all platforms; r=mshal

Comment 8

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/b4a5ab45942f
https://hg.mozilla.org/mozilla-central/rev/3d7619511fe8
https://hg.mozilla.org/mozilla-central/rev/457cdbb01def