Closed Bug 1415389 Opened 2 years ago Closed 2 years ago

Make ChromeUtils a namespace

Categories

(Core :: DOM: Core & HTML, enhancement)

53 Branch
enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla58
Tracking Status
firefox58 --- fixed

People

(Reporter: bzbarsky, Assigned: bzbarsky)

Details

Attachments

(1 file)

Lets us remove some hackery we have now with NoInterfaceObject.

IDL namespaces don't support inheritance, and ThreadSafeChromeUtils is too long to type or read anyway, so I'm going to just have a partial namespace with a more restricted exposure set for the bits that are not threadsafe.
MozReview-Commit-ID: 9ysAeaBMNVt
Attachment #8926200 - Flags: review?(kmaglione+bmo)
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
> Lets us remove some hackery we have now with NoInterfaceObject.

Er, with "concrete: False".
Comment on attachment 8926200 [details] [diff] [review]
Make ChromeUtils a WebIDL namespace.  Remove ThreadSafeChromeUtils

Review of attachment 8926200 [details] [diff] [review]:
-----------------------------------------------------------------

::: devtools/docs/tools/memory-panel.md
@@ +87,5 @@
>  edges, and write these messages to disk before continuing the traversal to the
>  next node.
>  
>  This functionality is exposed to chrome JavaScript as the
>  `[ThreadSafe]ChromeUtils.saveHeapSnapshot` function. See

Nit: Can also remove [ThreadSafe]
Attachment #8926200 - Flags: review?(kmaglione+bmo) → review+
Good catch.
Pushed by bzbarsky@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/73352624f35c
Make ChromeUtils a WebIDL namespace.  Remove ThreadSafeChromeUtils.  r=kmag
https://hg.mozilla.org/mozilla-central/rev/73352624f35c
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.