1415418 - Minor Preferences.h cleanups

Status: RESOLVED FIXED

(Core :: Preferences: Backend, enhancement)

Comment 1

[Nicholas Nethercote [inactive]]

Attachment: Bug 1415418 - Reorder Preferences.h. .

The various getters and setters are in a confusing order. This patch puts them
in a more sensible order. It also streamlines the comments, which were
generally low-value and in some cases incorrect.

Review commit: https://reviewboard.mozilla.org/r/197506/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/197506/

Comment 2

[Nicholas Nethercote [inactive]]

Attachment: Bug 1415418 - Simplify GetUint(). .

This makes it just like GetDefaultUint().

Review commit: https://reviewboard.mozilla.org/r/197508/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/197508/

Comment 3

[Code Review Bot [:reviewbot]]

Comment on attachment 8926244 [details]
Bug 1415418 - Reorder Preferences.h. .

https://reviewboard.mozilla.org/r/197506/#review202726


C/C++ static analysis found 0 defects in this patch.

You can run this analysis locally with: `./mach static-analysis check path/to/file.cpp`

Comment 4

[Code Review Bot [:reviewbot]]

Comment on attachment 8926245 [details]
Bug 1415418 - Simplify GetUint(). .

https://reviewboard.mozilla.org/r/197508/#review202728


C/C++ static analysis found 0 defects in this patch.

You can run this analysis locally with: `./mach static-analysis check path/to/file.cpp`

Comment 5

[Mike Hommey [:glandium]]

Comment on attachment 8926244 [details]
Bug 1415418 - Reorder Preferences.h. .

https://reviewboard.mozilla.org/r/197506/#review202744

Comment 6

[Mike Hommey [:glandium]]

Comment on attachment 8926245 [details]
Bug 1415418 - Simplify GetUint(). .

https://reviewboard.mozilla.org/r/197508/#review202748

Comment 7

[Nicholas Nethercote [inactive]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/017d8233ee85a6643e0e23e11509d2a4d889da08
Bug 1415418 - Reorder Preferences.h. r=glandium.

https://hg.mozilla.org/integration/mozilla-inbound/rev/e368fe33afd342ed8540df982ce4ef0d37617940
Bug 1415418 - Simplify GetUint(). r=glandium.

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/017d8233ee85
https://hg.mozilla.org/mozilla-central/rev/e368fe33afd3