Status
()
People
(Reporter: stransky, Assigned: stransky)
Tracking
(Blocks: 1 bug)
Firefox Tracking Flags
(firefox59 fixed)
Details
MozReview Requests
()
| Submitter | Diff | Changes | Open Issues | Last Updated |
|---|---|---|---|---|
| Loading... | ||||
| Error loading review requests: | ||||
Attachments
(3 attachments)
We have all patches landed so we can build Gtk+ with CAN_DRAW_IN_TITLEBAR=1 The titlebar rendering is still disabled by "widget.allow-client-side-decoration" preference.
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
(Assignee) | |
Updated•2 months ago
|
||
Assignee: nobody → stransky
Summary: Define CAN_DRAW_IN_TITLEBAR for Gtk+ → Build Linux/Gtk+ with titlebar rendering enabled
|
||
Comment 4•2 months ago
|
||
| mozreview-review | ||
Comment on attachment 8926313 [details] Bug 1415481 - set browser.tabs.drawInTitlebar to true unix platforms, https://reviewboard.mozilla.org/r/197598/#review202852
Attachment #8926313 -
Flags: review+
|
|
||
Comment 5•2 months ago
|
||
| mozreview-review | ||
Comment on attachment 8926314 [details] Bug 1415481 - make widget.allow-client-side-decoration visible, https://reviewboard.mozilla.org/r/197600/#review202854
Attachment #8926314 -
Flags: review+
|
|
||
Comment 6•2 months ago
|
||
| mozreview-review | ||
Comment on attachment 8926312 [details] Bug 1415481 - Define CAN_DRAW_IN_TITLEBAR for Gtk+ builds, https://reviewboard.mozilla.org/r/197596/#review202856
Attachment #8926312 -
Flags: review+
|
||
Comment 7•2 months ago
|
||
| mozreview-review | ||
Comment on attachment 8926312 [details] Bug 1415481 - Define CAN_DRAW_IN_TITLEBAR for Gtk+ builds, https://reviewboard.mozilla.org/r/197596/#review203182
Attachment #8926312 -
Flags: review?(mh+mozilla) → review+
|
|
||
Comment 8•2 months ago
|
||
| mozreview-review | ||
Comment on attachment 8926313 [details] Bug 1415481 - set browser.tabs.drawInTitlebar to true unix platforms, https://reviewboard.mozilla.org/r/197598/#review203184 ::: browser/app/profile/firefox.js:472 (Diff revision 1) > pref("browser.tabs.tabClipWidth", 140); > pref("browser.tabs.tabMinWidth", 76); > -#ifdef UNIX_BUT_NOT_MAC > -pref("browser.tabs.drawInTitlebar", false); > -#else > pref("browser.tabs.drawInTitlebar", true); Shouldn't this only me true if CAN_DRAW_IN_TITLEBAR is set?
Attachment #8926313 -
Flags: review?(mh+mozilla)
|
|
||
Comment 9•2 months ago
|
||
| mozreview-review | ||
Comment on attachment 8926314 [details] Bug 1415481 - make widget.allow-client-side-decoration visible, https://reviewboard.mozilla.org/r/197600/#review203186
Attachment #8926314 -
Flags: review?(mh+mozilla) → review+
|
|
(Assignee) | |
Comment 10•2 months ago
|
||
| mozreview-review | ||
Comment on attachment 8926313 [details] Bug 1415481 - set browser.tabs.drawInTitlebar to true unix platforms, https://reviewboard.mozilla.org/r/197598/#review203286 ::: browser/app/profile/firefox.js:472 (Diff revision 1) > pref("browser.tabs.tabClipWidth", 140); > pref("browser.tabs.tabMinWidth", 76); > -#ifdef UNIX_BUT_NOT_MAC > -pref("browser.tabs.drawInTitlebar", false); > -#else > pref("browser.tabs.drawInTitlebar", true); CAN_DRAW_IN_TITLEBAR is not a global one and it's not defined here...we'd need to add it for this dir or move it to a global config.
|
|
(Assignee) | |
Comment 11•2 months ago
|
||
| mozreview-review | ||
Comment on attachment 8926313 [details] Bug 1415481 - set browser.tabs.drawInTitlebar to true unix platforms, https://reviewboard.mozilla.org/r/197598/#review203690 ::: browser/app/profile/firefox.js:472 (Diff revision 1) > pref("browser.tabs.tabClipWidth", 140); > pref("browser.tabs.tabMinWidth", 76); > -#ifdef UNIX_BUT_NOT_MAC > -pref("browser.tabs.drawInTitlebar", false); > -#else > pref("browser.tabs.drawInTitlebar", true); I added the CAN_DRAW_IN_TITLEBAR define to browser/app as the global define will need more (potentialy intrusive) work.
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
|
(Assignee) | |
Comment 14•2 months ago
|
||
Dau, can you please check the updated patch at https://reviewboard.mozilla.org/r/197598/diff/2/ ? It confuses me that I attached a new one but mozreview keeps to show r+ there. Thanks!
Flags: needinfo?(dao+bmo)
|
|
(Assignee) | |
Updated•2 months ago
|
||
Attachment #8926313 -
Flags: review?(mh+mozilla)
|
|
||
Comment 15•2 months ago
|
||
(In reply to Martin Stránský [:stransky] from comment #14) > Dau, can you please check the updated patch at > https://reviewboard.mozilla.org/r/197598/diff/2/ ? It confuses me that I > attached a new one but mozreview keeps to show r+ there. Thanks! Looks good. Reading browser.tabs.drawInTitlebar should be guarded by CAN_DRAW_IN_TITLEBAR, so imho the original patch was fine too.
Flags: needinfo?(dao+bmo)
|
|
(Assignee) | |
Comment 16•2 months ago
|
||
Okay, Thanks!
|
|
||
Comment 17•2 months ago
|
||
| mozreview-review | ||
Comment on attachment 8926313 [details] Bug 1415481 - set browser.tabs.drawInTitlebar to true unix platforms, https://reviewboard.mozilla.org/r/197598/#review204636
Attachment #8926313 -
Flags: review?(mh+mozilla) → review+
|
|
(Assignee) | |
Updated•2 months ago
|
||
Keywords: checkin-needed
|
||
Comment 18•2 months ago
|
||
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again. hg error in cmd: hg rebase -s 685393f0e8be -d 32de83b016c9: rebasing 434022:685393f0e8be "Bug 1415481 - Define CAN_DRAW_IN_TITLEBAR for Gtk+ builds, r=dao,glandium" merging toolkit/modules/moz.build warning: conflicts while merging toolkit/modules/moz.build! (edit, then use 'hg resolve --mark') unresolved conflicts (see hg resolve, then hg rebase --continue)
|
|
(Assignee) | |
Updated•2 months ago
|
||
Keywords: checkin-needed
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
||
Comment 22•2 months ago
|
||
Pushed by stransky@redhat.com: https://hg.mozilla.org/integration/autoland/rev/53463889cdb6 Define CAN_DRAW_IN_TITLEBAR for Gtk+ builds, r=dao,glandium https://hg.mozilla.org/integration/autoland/rev/4d8dc538cb2d set browser.tabs.drawInTitlebar to true on windows, cocoa and gtk3 widgets, r=dao,glandium https://hg.mozilla.org/integration/autoland/rev/a00865a5bd43 make widget.allow-client-side-decoration visible, r=dao,glandium
|
||
Comment 23•2 months ago
|
||
Backed out 3 changesets (bug 1415481) for failing bcs in browser/base/content/test/general/browser_tabbar_big_widgets.js r=backout on a CLOSED TREE https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=a00865a5bd43bddfe517535766f9dafd5fe463c0&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable&selectedJob=144931822 https://hg.mozilla.org/integration/autoland/rev/c63f47691bc407aa1be126c0805087d3d393b762
Flags: needinfo?(stransky)
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
|
(Assignee) | |
Comment 26•2 months ago
|
||
Let's try the simple patch which enables browser.tabs.drawInTitlebar for all platforms.
Flags: needinfo?(stransky)
|
|
||
Comment 27•2 months ago
|
||
Pushed by stransky@redhat.com: https://hg.mozilla.org/integration/autoland/rev/2e814a8043d8 Define CAN_DRAW_IN_TITLEBAR for Gtk+ builds, r=dao,glandium https://hg.mozilla.org/integration/autoland/rev/d27dcb603c19 set browser.tabs.drawInTitlebar to true unix platforms, r=dao,glandium https://hg.mozilla.org/integration/autoland/rev/63224d6e543c make widget.allow-client-side-decoration visible, r=dao,glandium
|
|
||
Comment 28•2 months ago
|
||
(In reply to Martin Stránský [:stransky] from comment #26) > Let's try the simple patch which enables browser.tabs.drawInTitlebar for all > platforms. That sounds wrong.
|
||
Comment 29•2 months ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/2e814a8043d8 https://hg.mozilla.org/mozilla-central/rev/d27dcb603c19 https://hg.mozilla.org/mozilla-central/rev/63224d6e543c
Status: NEW → RESOLVED
Last Resolved: 2 months ago
status-firefox59: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
|
||
Comment 30•2 months ago
|
||
I get spaces in both sides of my tab bar. After maximizing the left one disappears but the right one is still there. Setting browser.tabs.drawInTitlebar to false removes both. Is this expected behaviour? I'm on Arch Linux, with the Awesome WM.
|
||
Comment 31•2 months ago
|
||
Screenshots showing the added drag space: https://screenshots.mattn.ca/compare/?oldProject=mozilla-central&oldRev=e070277ec199fa96fa490ed52d33646a376d0d80&newProject=mozilla-central&newRev=60b9fa15e4272bb1d2b876235f346587be6f2424&filter=linux I guess that's intended to be shown by default.
|
|
(Assignee) | |
Comment 32•2 months ago
|
||
(In reply to Johann Hofmann [:johannh] from comment #31) > Screenshots showing the added drag space: > > https://screenshots.mattn.ca/compare/?oldProject=mozilla- > central&oldRev=e070277ec199fa96fa490ed52d33646a376d0d80&newProject=mozilla- > central&newRev=60b9fa15e4272bb1d2b876235f346587be6f2424&filter=linux > > I guess that's intended to be shown by default. Thanks. Let's solve that at Bug 1418829.
|
||
Updated•2 months ago
|
||
status-firefox58: affected → ---
You need to log in
before you can comment on or make changes to this bug.
Description
•