1415522 - PlacesTransactions.Tag fails if a URL is already tagged

Status: VERIFIED FIXED

(Toolkit :: Places, defect)

Description

[Mark Banner (:standard8)]

STR:

1) Open the Bookmarks window
2) In one of the folders, create a few bookmarks, including one that has the same URL as one of the others.
3) Tag one of the bookmarks, e.g. "test"
4) Select all the bookmarks in the folder and right-click, select "copy"
5) In the left-hand pane, expand "Tags" if need be, and right-click on the "test" tag, then select "Paste"

Expected Results

=> Action completes with no errors

Actual Results

=> Not all items are tagged, on the console:

Exception { name: "NS_ERROR_ILLEGAL_VALUE", message: "Invalid value for tags", result: 2147942487, filename: "file:///Users/mark/dev/gecko/objdir…", lineNumber: 138, columnNumber: 0, data: null, stack: "TS_tagURI@file:///Users/mark/dev/ge…", location: XPCWrappedNative_NoHelper }

This also happens with drag and drop.

Works fine with Async Transactions disabled.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1415522 - PlacesTransactions.Tag should take account of a URL that is already tagged.

Review commit: https://reviewboard.mozilla.org/r/197628/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/197628/

Comment 2

[Marco Bonardo [:mak]]

Comment on attachment 8926353 [details]
Bug 1415522 - PlacesTransactions.Tag should take account of a URL that is already tagged.

https://reviewboard.mozilla.org/r/197628/#review202888

cool, thanks.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ee5be9ad894e
PlacesTransactions.Tag should take account of a URL that is already tagged. r=mak

Comment 4

[Sebastian Hengst [:aryx] (needinfo on intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/ee5be9ad894e

Comment 5

[Hani Yacoub]

Build ID: 20171112220346
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:58.0) Gecko/20100101 Firefox/58.0

Verified as fixed on Firefox Nightly 58.0a1 on Windows 10 x 64, Windows 7 x32, Mac OS X 10.12 and Ubuntu 16.04 x64.