Closed Bug 1415522 Opened 4 years ago Closed 4 years ago

PlacesTransactions.Tag fails if a URL is already tagged

Categories

(Toolkit :: Places, defect)

defect
Not set
normal

Tracking

()

VERIFIED FIXED
mozilla58
Tracking Status
firefox-esr52 --- unaffected
firefox56 --- disabled
firefox57 --- disabled
firefox58 --- verified

People

(Reporter: standard8, Assigned: standard8)

Details

(Keywords: regression, Whiteboard: [fxsearch])

Attachments

(1 file)

STR:

1) Open the Bookmarks window
2) In one of the folders, create a few bookmarks, including one that has the same URL as one of the others.
3) Tag one of the bookmarks, e.g. "test"
4) Select all the bookmarks in the folder and right-click, select "copy"
5) In the left-hand pane, expand "Tags" if need be, and right-click on the "test" tag, then select "Paste"

Expected Results

=> Action completes with no errors

Actual Results

=> Not all items are tagged, on the console:

Exception { name: "NS_ERROR_ILLEGAL_VALUE", message: "Invalid value for tags", result: 2147942487, filename: "file:///Users/mark/dev/gecko/objdir…", lineNumber: 138, columnNumber: 0, data: null, stack: "TS_tagURI@file:///Users/mark/dev/ge…", location: XPCWrappedNative_NoHelper }

This also happens with drag and drop.

Works fine with Async Transactions disabled.
Comment on attachment 8926353 [details]
Bug 1415522 - PlacesTransactions.Tag should take account of a URL that is already tagged.

https://reviewboard.mozilla.org/r/197628/#review202888

cool, thanks.
Attachment #8926353 - Flags: review?(mak77) → review+
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ee5be9ad894e
PlacesTransactions.Tag should take account of a URL that is already tagged. r=mak
https://hg.mozilla.org/mozilla-central/rev/ee5be9ad894e
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
Build ID: 20171112220346
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:58.0) Gecko/20100101 Firefox/58.0

Verified as fixed on Firefox Nightly 58.0a1 on Windows 10 x 64, Windows 7 x32, Mac OS X 10.12 and Ubuntu 16.04 x64.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.