Closed Bug 1415529 Opened 2 years ago Closed 2 years ago

Remove unused autocomplete-textbox-container from the autocomplete binding

Categories

(Toolkit :: XUL Widgets, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla58
Tracking Status
firefox58 --- fixed

People

(Reporter: dao, Assigned: dao)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

No description provided.
I also tried to remove urlbar-textbox-container but it breaks this test in an obscure way:

> 7 INFO TEST-UNEXPECTED-FAIL | browser/components/customizableui/test/browser_962069_drag_to_overflow_chevron.js | Uncaught exception - at chrome://mochikit/content/tests/SimpleTest/EventUtils.js:2161 - TypeError: _EU_maybeWrap(...) is null
> Stack trace:
>     createDragEventObject@chrome://mochikit/content/tests/SimpleTest/EventUtils.js:2161:38
>     synthesizeDragOver@chrome://mochikit/content/tests/SimpleTest/EventUtils.js:2249:15
>     @chrome://mochitests/content/browser/browser/components/customizableui/test/browser_962069_drag_to_overflow_chevron.js:33:34
>     Async*Tester_execTest/<@chrome://mochikit/content/browser-test.js:1060:21
>     Tester_execTest@chrome://mochikit/content/browser-test.js:1051:9
>     Tester.prototype.nextTest</<@chrome://mochikit/content/browser-test.js:951:9
>     SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:795:59
Comment on attachment 8926350 [details]
Bug 1415529 - Remove unused autocomplete-textbox-container from the autocomplete binding.

https://reviewboard.mozilla.org/r/197620/#review203010

Nice simplification and the screenshot comparison shows no changes, r=me.

https://screenshots.mattn.ca/compare/?oldProject=try&oldRev=9c33d3f619a42132272565d94443d1671b30b163&newProject=try&newRev=56b70453b1bb03a67089a4599b4be07dbe6a75c9
Attachment #8926350 - Flags: review?(bgrinstead) → review+
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f3cbb780f180
Remove unused autocomplete-textbox-container from the autocomplete binding. r=bgrins
https://hg.mozilla.org/mozilla-central/rev/f3cbb780f180
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
Depends on: 1415850
Blocks: 1514505
You need to log in before you can comment on or make changes to this bug.