Closed Bug 1415538 Opened 7 years ago Closed 7 years ago

Remove dead frame construction code.

Categories

(Core :: Layout, enhancement)

Product:
Core
Component:
Layout
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla58
Tracking Flags:
Tracking Status
firefox58 --- fixed

People

(Reporter: emilio, Assigned: emilio)

Details

Attachments

(1 file)

Bug 1415538: Remove dead frame construction code (InsertFirstLineFrames).
59 bytes, text/x-review-board-request
MatsPalmgren_bugz
: review+
Details 
      No description provided.
Comment on attachment 8926356 [details]
Bug 1415538: Remove dead frame construction code (InsertFirstLineFrames).

https://reviewboard.mozilla.org/r/197636/#review202906

::: commit-message-40df5:1
(Diff revision 1)
> +Bug 1415538: Remove dead frame construction code. r?mats
> +
> +This code has been dead for a long time, and I don't think it's worth to keep it
> +around. It's in the VCS history anyway.

nit: the commit message would benefit from being a bit more specific IMO.

How about:
Bug 1415538: Remove dead frame construction code (InsertFirstLineFrames)

InsertFirstLineFrames has been dead ...
Attachment #8926356 - Flags: review?(mats) → review+
Comment on attachment 8926356 [details]
Bug 1415538: Remove dead frame construction code (InsertFirstLineFrames).

https://reviewboard.mozilla.org/r/197636/#review202910

::: commit-message-40df5:1
(Diff revision 1)
> +Bug 1415538: Remove dead frame construction code. r?mats
> +
> +This code has been dead for a long time, and I don't think it's worth to keep it
> +around. It's in the VCS history anyway.

Agreed, will do :)
Pushed by ecoal95@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/6646fb7959a8
Remove dead frame construction code (InsertFirstLineFrames). r=mats
https://hg.mozilla.org/mozilla-central/rev/6646fb7959a8
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox58: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
Assignee: nobody → emilio
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: