Closed Bug 1415568 Opened 2 years ago Closed 2 years ago

Support applying patches (with relative paths) to Windows clang

Categories

(Testing :: Code Coverage, enhancement)

Version 3
enhancement
Not set

Tracking

(firefox58 fixed)

RESOLVED FIXED
mozilla58
Tracking Status
firefox58 --- fixed

People

(Reporter: marco, Assigned: marco)

References

Details

Attachments

(1 file, 1 obsolete file)

Currently, build-clang.py fails if you add some patches to clang-win32.json.
Attached patch Patch (obsolete) — Splinter Review
Attachment #8926416 - Flags: review?(nfroyd)
Attached patch PatchSplinter Review
Attachment #8926416 - Attachment is obsolete: true
Attachment #8926416 - Flags: review?(nfroyd)
Attachment #8926418 - Flags: review?(nfroyd)
Comment on attachment 8926418 [details] [diff] [review]
Patch

Review of attachment 8926418 [details] [diff] [review]:
-----------------------------------------------------------------

Doh!  Thanks for catching that.
Attachment #8926418 - Flags: review?(nfroyd) → review+
There are already some patches at: https://dxr.mozilla.org/mozilla-central/source/build/build-clang/clang-win32.json

I think I must have worked around this by giving longer paths. I'm guessing you'll need to update the json file to account for this fix.
(In reply to David Major [:dmajor] from comment #4)
> There are already some patches at:
> https://dxr.mozilla.org/mozilla-central/source/build/build-clang/clang-win32.
> json
> 
> I think I must have worked around this by giving longer paths. I'm guessing
> you'll need to update the json file to account for this fix.

They were added recently (maybe when we switched to vs2017?). I'll fix the paths to be relative so we have the same format in the Linux and Windows JSON files.
Summary: Support applying patches to Windows clang → Support applying patches (with relative paths) to Windows clang
Pushed by mcastelluccio@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a06f5967bcb6
Support applying patches to Windows clang. r=froydnj
https://hg.mozilla.org/mozilla-central/rev/a06f5967bcb6
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in before you can comment on or make changes to this bug.