Closed Bug 1415584 Opened 2 years ago Closed 2 years ago

Autophone - is running unit tests on mozilla-release unintentionally

Categories

(Testing :: Autophone, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: bc, Assigned: bc)

References

Details

Attachments

(1 file)

https://treeherder.mozilla.org/#/jobs?repo=mozilla-release&filter-searchStr=autophone&fromchange=e512c14a04068f69369ef365642ba1ebb05dc3c5&group_state=expanded&tochange=ea14b85abeac942084437602be8486b410e4bfbd

shows that we have run the unit tests on mozilla-release twice in the last week. The intent was to disable the unit tests on release due to issues which have arisen in the past which have not been resolved on release as of yet.

the tests/production-autophone-1.ini file contains:

[runtestsremote.py Mdm1 opt]
config = ../configs/mochitests-dom-media-settings-opt.ini
nexus-5-07 = try autoland mozilla-inbound mozilla-central ;mozilla-beta mozilla-release
pixel-05 = try autoland mozilla-inbound mozilla-central ;mozilla-beta mozilla-release

[runtestsremote.py Mdm1 debug]
config = ../configs/mochitests-dom-media-settings-debug.ini
nexus-5-07 = try autoland mozilla-inbound mozilla-central ;mozilla-beta mozilla-release
pixel-06 = try autoland mozilla-inbound mozilla-central ;mozilla-beta mozilla-release

The intent was that the ; inline comment would prevent mozilla-beta and mozilla-release from being tested while making the config files clear as to what was ultimately desired in terms of repos to be tested and the currently disabled repos.
ConfigParser properly handles the ; comment in ini files but TestManifest from manifestparser does not. We can manually strip the commented repos from the TestManifest and work around the issue.
Attachment #8926932 - Flags: review?(gbrown)
Comment on attachment 8926932 [details] [diff] [review]
bug-1415584-v1.patch

Review of attachment 8926932 [details] [diff] [review]:
-----------------------------------------------------------------

Seems reasonable.

As an alternative, I think you could use # instead of ; for inline manifest comments.
Attachment #8926932 - Flags: review?(gbrown) → review+
The reason I was using ; instead of # is that ConfigParser doesn't handle inline # and I use it elsewhere to parse the test manifests. Geez. Let's just go with this for now.
https://github.com/mozilla/autophone/commit/a14ca7c0a374431315928aa540336641a6b67bf2
deploying shortly.
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.