Avoid "leaking" use of HitTestingTreeNode outside GetTargetAPZC

NEW
Unassigned

Status

()

Core
Graphics: WebRender
P3
normal
12 days ago
12 days ago

People

(Reporter: kats, Unassigned)

Tracking

(Blocks: 1 bug)

Other Branch
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox57 unaffected, firefox58 unaffected)

Details

(Whiteboard: [wr-reserve][gfx-noted])

If we want to proceed with bug 1389149 one of the things I'd like to do is not build the HitTestingTreeNode structure in APZCTreeManager when webrender is enabled. This structure is primarily used for hit-testing, which will be offloaded into WR. However this structure is also used for getting scrollbar info in a couple of places - one is via the out-param in GetTargetAPZC [1] and the other is via the return value of FindScrollThumbNode [2]. Instead of having these places use a HitTestingTreeNode I'd like to create another data structure that contains the necessary scrollbar/scrollthumb info, and that can be created without a HitTestingTreeNode in the webrender-enabled scenario.

Filing this bug to track that work.

[1] http://searchfox.org/mozilla-central/rev/ed212c79cfe86357e9a5740082b9364e7f6e526f/gfx/layers/apz/src/APZCTreeManager.h#487
[2] http://searchfox.org/mozilla-central/rev/ed212c79cfe86357e9a5740082b9364e7f6e526f/gfx/layers/apz/src/APZCTreeManager.cpp#2285

Updated

12 days ago
Whiteboard: [gfx-noted][wr-mvp][triage] → [wr-mvp] [triage][gfx-noted]

Updated

12 days ago
Whiteboard: [wr-mvp] [triage][gfx-noted] → [wr-reserve][gfx-noted]
Blocks: 1386665
status-firefox57: --- → unaffected
status-firefox58: --- → unaffected
You need to log in before you can comment on or make changes to this bug.