1415617 - Allow specifying mozconfig in mozharness as fragments, rather than repeating the entire path everywhere.

Status: RESOLVED FIXED

(Release Engineering :: Applications: MozharnessCore, enhancement)

Description

[Tom Prince [:tomprince]]

Looking at `src_mozconfig`, it appears the format is always something like `{MOZ_BUILD_APP}/config/mozconfigs/{platform}/{variant}`. Currently, I'd need to override `src_mozconfig` in its entirety for every configuration because all the parts of it are hard-coded.

Comment 1

[Tom Prince [:tomprince]]

Attachment: Bug 1415617: Allow specifying mozconfig in mozharness as fragments, rather than repeating the entire path everywhere.

Review commit: https://reviewboard.mozilla.org/r/197774/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/197774/

Comment 2

[Tom Prince [:tomprince]]

Attachment: Bug 1415617: Update desktop mozharness configs to specify mozconfig in parts.

Review commit: https://reviewboard.mozilla.org/r/197776/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/197776/

Comment 3

[Tom Prince [:tomprince]]

Comment on attachment 8926543 [details]
Bug 1415617: Allow specifying mozconfig in mozharness as fragments, rather than repeating the entire path everywhere.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/197774/diff/1-2/

Comment 4

[Tom Prince [:tomprince]]

Comment on attachment 8926544 [details]
Bug 1415617: Update desktop mozharness configs to specify mozconfig in parts.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/197776/diff/1-2/

Comment 5

[Jordan Lund (:jlund)]

I can have a look at these tomorrow assuming no further distractions with 57.0. Failing that and these are blocking, we should r? others who have contributed to mozharness build scripts: callek, aki, rail, and mihai are all good candidates.

Comment 6

[Tom Prince [:tomprince]]

Comment on attachment 8926543 [details]
Bug 1415617: Allow specifying mozconfig in mozharness as fragments, rather than repeating the entire path everywhere.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/197774/diff/2-3/

Comment 7

[Tom Prince [:tomprince]]

Comment on attachment 8926544 [details]
Bug 1415617: Update desktop mozharness configs to specify mozconfig in parts.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/197776/diff/2-3/

Comment 8

[Jordan Lund (:jlund)]

Comment on attachment 8926543 [details]
Bug 1415617: Allow specifying mozconfig in mozharness as fragments, rather than repeating the entire path everywhere.

https://reviewboard.mozilla.org/r/197774/#review205178

On one hand, it's unfortunate how complicated this was before hand. On the other hand, I'm impressed that you worked with it. This patch helps readability but doesn't remove complexity. I kind of wish we had mach and taskgraph handle all of this and mozharness simply ran the script but that's out of scope here.

::: testing/mozharness/mozharness/mozilla/building/buildbase.py:255
(Diff revision 3)
> +    have_composite_mozconfig = COMPOSITE_KEYS <= set(config.keys())
> +    have_partial_composite_mozconfig = len(COMPOSITE_KEYS & set(config.keys())) > 0

nice

Comment 9

[Jordan Lund (:jlund)]

Comment on attachment 8926544 [details]
Bug 1415617: Update desktop mozharness configs to specify mozconfig in parts.

https://reviewboard.mozilla.org/r/197776/#review205182

Comment 10

[Tom Prince [:tomprince]]

Comment on attachment 8926543 [details]
Bug 1415617: Allow specifying mozconfig in mozharness as fragments, rather than repeating the entire path everywhere.

https://reviewboard.mozilla.org/r/197774/#review205178

If you file a bug describing what you'd like the end state to be, I could probably implement (at low priority).

Comment 11

[Tom Prince [:tomprince]]

Comment on attachment 8926543 [details]
Bug 1415617: Allow specifying mozconfig in mozharness as fragments, rather than repeating the entire path everywhere.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/197774/diff/3-4/

Comment 12

[Tom Prince [:tomprince]]

Comment on attachment 8926544 [details]
Bug 1415617: Update desktop mozharness configs to specify mozconfig in parts.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/197776/diff/3-4/

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b8cafc100e2a
Allow specifying mozconfig in mozharness as fragments, rather than repeating the entire path everywhere. r=jlund
https://hg.mozilla.org/integration/autoland/rev/967cec5ff7ad
Update desktop mozharness configs to specify mozconfig in parts. r=jlund

Comment 14

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/b8cafc100e2a
https://hg.mozilla.org/mozilla-central/rev/967cec5ff7ad