Closed Bug 1415617 Opened 2 years ago Closed 2 years ago

Allow specifying mozconfig in mozharness as fragments, rather than repeating the entire path everywhere.

Categories

(Release Engineering :: Applications: MozharnessCore, enhancement)

enhancement
Not set

Tracking

(firefox59 fixed)

RESOLVED FIXED
Tracking Status
firefox59 --- fixed

People

(Reporter: tomprince, Assigned: tomprince)

References

Details

Attachments

(2 files)

Looking at `src_mozconfig`, it appears the format is always something like `{MOZ_BUILD_APP}/config/mozconfigs/{platform}/{variant}`. Currently, I'd need to override `src_mozconfig` in its entirety for every configuration because all the parts of it are hard-coded.
Assignee: nobody → mozilla
Status: NEW → ASSIGNED
I can have a look at these tomorrow assuming no further distractions with 57.0. Failing that and these are blocking, we should r? others who have contributed to mozharness build scripts: callek, aki, rail, and mihai are all good candidates.
Comment on attachment 8926543 [details]
Bug 1415617: Allow specifying mozconfig in mozharness as fragments, rather than repeating the entire path everywhere.

https://reviewboard.mozilla.org/r/197774/#review205178

On one hand, it's unfortunate how complicated this was before hand. On the other hand, I'm impressed that you worked with it. This patch helps readability but doesn't remove complexity. I kind of wish we had mach and taskgraph handle all of this and mozharness simply ran the script but that's out of scope here.

::: testing/mozharness/mozharness/mozilla/building/buildbase.py:255
(Diff revision 3)
> +    have_composite_mozconfig = COMPOSITE_KEYS <= set(config.keys())
> +    have_partial_composite_mozconfig = len(COMPOSITE_KEYS & set(config.keys())) > 0

nice
Attachment #8926543 - Flags: review?(jlund) → review+
Comment on attachment 8926544 [details]
Bug 1415617: Update desktop mozharness configs to specify mozconfig in parts.

https://reviewboard.mozilla.org/r/197776/#review205182
Attachment #8926544 - Flags: review?(jlund) → review+
Comment on attachment 8926543 [details]
Bug 1415617: Allow specifying mozconfig in mozharness as fragments, rather than repeating the entire path everywhere.

https://reviewboard.mozilla.org/r/197774/#review205178

If you file a bug describing what you'd like the end state to be, I could probably implement (at low priority).
Pushed by mozilla@hocat.ca:
https://hg.mozilla.org/integration/autoland/rev/b8cafc100e2a
Allow specifying mozconfig in mozharness as fragments, rather than repeating the entire path everywhere. r=jlund
https://hg.mozilla.org/integration/autoland/rev/967cec5ff7ad
Update desktop mozharness configs to specify mozconfig in parts. r=jlund
https://hg.mozilla.org/mozilla-central/rev/b8cafc100e2a
https://hg.mozilla.org/mozilla-central/rev/967cec5ff7ad
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.