1415618 - Allow specifying additional paths to search for mozharness configs.

Status: RESOLVED FIXED

(Release Engineering :: Applications: MozharnessCore, enhancement)

Description

[Tom Prince [:tomprince]]

pass additional config search path to mozharness scripts: I'd like to put thunderbird specific configuration in comm-central, and need someway to reference them, and I would rather not have to pass absolute paths. Something like:

   .../fx_desktop_build.py --search-path comm/mozharness/config --config builds/releng_base_linux_64_builds.py --config builds/thunderbird_base.py

  where builds/thunderbird_base.py lives in comm/mozhanress/config/builds/thunderbird_base.py

Comment 1

[Tom Prince [:tomprince]]

Attachment: Bug 1415618: When looking for a downloaded mozharness config, only look where it was put.

Review commit: https://reviewboard.mozilla.org/r/199906/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/199906/

Comment 2

[Tom Prince [:tomprince]]

Attachment: Bug 1415618: Use path relative to mozharness config modules to find configs.

Review commit: https://reviewboard.mozilla.org/r/199908/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/199908/

Comment 3

[Tom Prince [:tomprince]]

Attachment: Bug 1415618: Allow specifying extra paths to search for config files mozharness.

Review commit: https://reviewboard.mozilla.org/r/199910/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/199910/

Comment 4

[Tom Prince [:tomprince]]

Attachment: Bug 1415618: Add support to taskcluster to specifying extra paths to mozharness.

Review commit: https://reviewboard.mozilla.org/r/199912/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/199912/

Comment 5

[Jordan Lund (:jlund)]

Comment on attachment 8928677 [details]
Bug 1415618: When looking for a downloaded mozharness config, only look where it was put.

https://reviewboard.mozilla.org/r/199906/#review205162

Comment 6

[Jordan Lund (:jlund)]

Comment on attachment 8928678 [details]
Bug 1415618: Use path relative to mozharness config modules to find configs.

https://reviewboard.mozilla.org/r/199908/#review205166

Comment 7

[Jordan Lund (:jlund)]

Comment on attachment 8928679 [details]
Bug 1415618: Allow specifying extra paths to search for config files mozharness.

https://reviewboard.mozilla.org/r/199910/#review205170

Comment 8

[Jordan Lund (:jlund)]

Comment on attachment 8928680 [details]
Bug 1415618: Add support to taskcluster to specifying extra paths to mozharness.

https://reviewboard.mozilla.org/r/199912/#review205176

I'm a little unfamiliar with some of the tc config setup but I believe this patch is fine and should work as expected.

Comment 9

[Tom Prince [:tomprince]]

Comment on attachment 8928677 [details]
Bug 1415618: When looking for a downloaded mozharness config, only look where it was put.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/199906/diff/1-2/

Comment 10

[Tom Prince [:tomprince]]

Comment on attachment 8928678 [details]
Bug 1415618: Use path relative to mozharness config modules to find configs.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/199908/diff/1-2/

Comment 11

[Tom Prince [:tomprince]]

Comment on attachment 8928679 [details]
Bug 1415618: Allow specifying extra paths to search for config files mozharness.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/199910/diff/1-2/

Comment 12

[Tom Prince [:tomprince]]

Comment on attachment 8928680 [details]
Bug 1415618: Add support to taskcluster to specifying extra paths to mozharness.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/199912/diff/1-2/

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/be3173822987
When looking for a downloaded mozharness config, only look where it was put. r=jlund
https://hg.mozilla.org/integration/autoland/rev/5ecdc55db739
Use path relative to mozharness config modules to find configs. r=jlund
https://hg.mozilla.org/integration/autoland/rev/780f67a36d6d
Allow specifying extra paths to search for config files mozharness. r=jlund
https://hg.mozilla.org/integration/autoland/rev/71510fd07ef5
Add support to taskcluster to specifying extra paths to mozharness. r=jlund

Comment 14

[Cristian Brindusan [:cbrindusan]]

Backed out 4 changesets (bug 1415618) for build bustage failures:

https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=71510fd07ef52f8539ed37968e2ec7ea9c1a5fdd 

https://treeherder.mozilla.org/logviewer.html#?job_id=145199332&repo=autoland&lineNumber=452

https://hg.mozilla.org/integration/autoland/rev/71510fd07ef52f8539ed37968e2ec7ea9c1a5fdd

Comment 15

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b89090531f6a
Backed out 4 changesets for build bustage failures. r=backout on a CLOSED TREE

Comment 16

[Tom Prince [:tomprince]]

Comment on attachment 8928677 [details]
Bug 1415618: When looking for a downloaded mozharness config, only look where it was put.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/199906/diff/2-3/

Comment 17

[Tom Prince [:tomprince]]

Comment on attachment 8928678 [details]
Bug 1415618: Use path relative to mozharness config modules to find configs.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/199908/diff/2-3/

Comment 18

[Tom Prince [:tomprince]]

Comment on attachment 8928679 [details]
Bug 1415618: Allow specifying extra paths to search for config files mozharness.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/199910/diff/2-3/

Comment 19

[Tom Prince [:tomprince]]

Comment on attachment 8928680 [details]
Bug 1415618: Add support to taskcluster to specifying extra paths to mozharness.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/199912/diff/2-3/

Comment 20

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/501306f6fc22
When looking for a downloaded mozharness config, only look where it was put. r=jlund
https://hg.mozilla.org/integration/autoland/rev/1258a1b9888f
Use path relative to mozharness config modules to find configs. r=jlund
https://hg.mozilla.org/integration/autoland/rev/796e3f06ba99
Allow specifying extra paths to search for config files mozharness. r=jlund
https://hg.mozilla.org/integration/autoland/rev/bcf4fd4217ef
Add support to taskcluster to specifying extra paths to mozharness. r=jlund

Comment 21

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/501306f6fc22
https://hg.mozilla.org/mozilla-central/rev/1258a1b9888f
https://hg.mozilla.org/mozilla-central/rev/796e3f06ba99
https://hg.mozilla.org/mozilla-central/rev/bcf4fd4217ef