1415623 - Preferences crash latest trunk

Status: RESOLVED FIXED

(SeaMonkey :: Preferences, defect)

Description

[Rocco Stilo]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:58.0) Gecko/20100101 Firefox/58.0 SeaMonkey/2.55a1
Build ID: 20171031003001

Steps to reproduce:

Downloaded new trunk today: It seems to work fine. When I select Preferences... menu item "Helper Applications" crash the program. It crashes when I select with the mouse and also when I selectitem menu via keyboard.

Comment 2

[Frank-Rainer Grahl (:frg)]

https://crash-stats.mozilla.com/report/index/61cc773c-73bd-4300-b73c-e44420171110#tab-details

XBL compat hack matched, please file a bug blocking bug 1374247. Selector: .handler-type

Comment 3

[Frank-Rainer Grahl (:frg)]

You are better with css than me. Any quick fix available?

Comment 5

[Stefan [:stefanh]]

(In reply to Frank-Rainer Grahl (:frg) from comment #3)
> You are better with css than me. Any quick fix available?

Hmm, there are 3 ".handler-type >" in cc (https://dxr.mozilla.org/comm-central/search?q=.handler-type&redirect=false). I'd say just remove the 3 ">":s. I don't have a fresh build handy, otherwise I would have tried myself. Note that there might be more places in cc where you have the same type of rules...

Comment 6

[Frank-Rainer Grahl (:frg)]

\suite\themes\classic\communicator\prefpanels.css:

Adding a .listcell-iconic seems to do the job in classic. No longer crashes and the icons look ok. Seems to be the same for modern.

> .handler-action > .listcell-iconic > .listcell-icon,
> .handler-type > .listcell-iconic > .listcell-icon {
>   height: 16px;
>   width: 16x;
> }

But I am not sure if this was ever right. In suite/common/pref/prefpanels.xml both items have 2 classes?

Comment 7

[Stefan [:stefanh]]

That's another listcell: https://dxr.mozilla.org/comm-central/rev/952762964f408e33d060dd1110cac0626ae5fa51/suite/common/pref/prefpanels.xml#33 (the one above is the "handler-type" one).

Comment 8

[Stefan [:stefanh]]

It would be interesting if you could trigger a crash for that one as well... I haven't investigated, but dxr tells me that the class is also used on menuitems (see suite/common/pref/pref-applications.js).

Comment 9

[Stefan [:stefanh]]

Actually, the "handler-action" also needs to be fixed since I get this when loading the prefpane:
"Hit MOZ_CRASH(XBL compat hack matched, please file a bug blocking bug 1374247. Selector: .handler-action) at /Users/stefan/moz/comm-central/mozilla/layout/style/nsCSSRuleProcessor.cpp:2499"

Comment 10

[Frank-Rainer Grahl (:frg)]

Attachment: 1415623-prefuncrash.patch

.listcell-icon and .listcell-label both have .listcell-iconic as the parent in listbox.xml so this should be correct.

No longer crashes in Modern and Classic. I don't see a difference in apperance under Windows compared to 2.53 so I assume it works :)

I think it just needs one review so whoever does the review might drop the second one.

Comment 11

[Stefan [:stefanh]]

Comment on attachment 8927599 [details] [diff] [review]
1415623-prefuncrash.patch

Uhm, wait a second.... You have this, dont you?

listcell-iconic handler-type
  listcell-icon
  listcell-label

So I don't think that'd work.

Comment 12

[Frank-Rainer Grahl (:frg)]

Attachment: 1415623-prefuncrash-V2.patch

As discussed on irc. Tested in Classic and Modern.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/00400455524e
Use dependent class selectors in "Preferences - Helper Applications" css. r=stefanh