1415649 - KeyError when a rule doesn't match an updateQuery that doesn't contain the SYSTEM_CAPABILITIES fields

Status: RESOLVED FIXED

(Release Engineering Graveyard :: Applications: Balrog (backend), enhancement, P1)

Description

[[e-mail] (:bhearsum)]

While doing some verifications for Firefox 57.0 we ended up querying URLs such as: https://aus5.mozilla.org/update/3/Firefox/56.0.1/20171002220106/WINNT_x86-msvc-x86/be/release-localtest/Windows_NT%2010.0.0.0%20(x86)/default/default/update.xml?force=1

These are somewhat invalid update URLs (we never have clients in the wild that use /update/3 and 56.0.1), but this as uncovered a small bug in the backend where "instructionSet", "memory", and "jaws" aren't available on the updateQuery when we try to access them at https://github.com/mozilla/balrog/blob/8304c3ed1dc0e9f3c2df28d6035d144171cfb332/auslib/db.py#L1789

Comment 1

[[e-mail] (:bhearsum)]

We seem to be hitting this in the wild with Avast queries, eg: https://aus5.mozilla.org/update/3/Firefox/56.0/20170831165232/WINNT_x86-msvc/en-US/release/Windows_NT%206.2.9200%20(x64)/default/default/update.xml?avast=1&force=1.

Comment 2

[[e-mail] (:bhearsum)]

This is breaking updates for at least some Avast users, I'm going to get this fixed ASAP.

Comment 3

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/balrog/pull/451

Comment 4

[[github robot]]

Commit pushed to master at https://github.com/mozilla/balrog

https://github.com/mozilla/balrog/commit/8347fadc70eb0c751745762856c038503f45ab44
bug 1415649: KeyError when a rule doesn't match an updateQuery that doesn't contain the SYSTEM_CAPABILITIES fields (#451). r=rail

Comment 5

[[e-mail] (:bhearsum)]

This is in production, and eliminated the exceptions we were getting there.