1415656 - Android sync stores bookmark dateAdded as string

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Android Sync, defect, P2)

Description

[Thom Chiovoloni [:tcsc] (ex-moco)]

It should be a number. The code that stores it is here http://searchfox.org/mozilla-central/source/mobile/android/services/src/main/java/org/mozilla/gecko/sync/repositories/domain/BookmarkRecord.java#288

It does the right thing when reading, although it's a bit oblivious to the fact that it caused it's own confusion there :p http://searchfox.org/mozilla-central/source/mobile/android/services/src/main/java/org/mozilla/gecko/sync/repositories/domain/BookmarkRecord.java#192

Luckily at least desktop will do the correct thing when ratcheting the timestamp backwards http://searchfox.org/mozilla-central/source/toolkit/components/places/PlacesSyncUtils.jsm#1032 (e.g. +existingMillis, when called from http://searchfox.org/mozilla-central/source/services/sync/modules/engines/bookmarks.js#131 )

I don't know iOS well enough to tell, I looked but it's not clear if it will do the right or wrong thing when reading or writing.

Comment 1

[:Grisha Kruglov]

Heh, that's a silly little bug. It seems that most we can do here is to stop sending it out as a string, keeping the reading logic intact. And double check iOS's behaviour in case of strings for the date.

Comment 2

[Thom Chiovoloni [:tcsc] (ex-moco)]

Attachment: Bug 1415656 - Fix android serializing dateAdded as a string in sync bookmark records

Review commit: https://reviewboard.mozilla.org/r/199486/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/199486/

Comment 3

[:Grisha Kruglov]

Comment on attachment 8928265 [details]
Bug 1415656 - Fix android serializing dateAdded as a string in sync bookmark records

https://reviewboard.mozilla.org/r/199486/#review205042

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/65f08f1b6fb2
Fix android serializing dateAdded as a string in sync bookmark records r=Grisha

Comment 5

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/65f08f1b6fb2