1415665 - Very long domain names overflow from the Highlight borders

Status: VERIFIED FIXED

(Firefox :: New Tab Page, defect)

Comment 1

[Itiel]

http://thisisverylongdomainname.thisisverylongdomainname.thisisverylongdomainname.thisisverylongdomainname.thisisverylongdomainname.thisisverylongdomainname.thisisverylongdomainname.thisisverylongdomainname.zelitomas.cf/
This is a valid URL, and when Firefox adds this to the Highlights, the attached screenshot is the result.
Using latest Nightly, Windows 10 x86.

Comment 2

[Itiel]

Attachment: Screenshot

Comment 3

[Ed Lee :Mardak]

Fixed by https://github.com/mozilla/activity-stream/pull/3838 to be uplifted via bug 1415812.

Comment 4

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/b4d1db669c93

Comment 5

[Ciprian Muresan [:cmuresan], Ecosystem QA]

I have verified that the issue is no longer reproducible using the latest Nightly 59.0a1 (Build ID 20171119220126) on Windows 10 x64, Mac 10.12.6 and Arch Linux x64.

Comment 6

[Gerry Chang [:gchang]]

Bug 1415812 has been uplifted to 58. We should not mark 58 fixed.

Comment 7

[Gerry Chang [:gchang]]

Sorry for typo in comment #6. What I meant is bug 1415812 has not been uplift to 58.

Comment 8

[Ed Lee :Mardak]

gchang says this bug has missed 58.0b8. It doesn't have a patch with beta approval flag. Please attach the appropriate patch without install.rdf.in changes and request approval ASAP.

Comment 9

[Andrei Oprea [:andreio]]

Attachment: Bug 1415665 - Very long domain names overflow from the Highlight borders.

Review commit: https://reviewboard.mozilla.org/r/204310/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/204310/

Comment 10

[Andrei Oprea [:andreio]]

Comment on attachment 8933382 [details]
Bug 1415665 - Very long domain names overflow from the Highlight borders.

Approval Request Comment
[Feature/Bug causing the regression]: https://github.com/sarracini/activity-stream/commit/35aaca49c0f31c8ed2487e4b95b3899c782b0914
[User impact if declined]: edge case when highlight cards have really long domain names it causes some overflow issues on Activity Stream
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: yes
[Needs manual test from QE? If yes, steps to reproduce]: 
[List of other uplifts needed for the feature/fix]:
[Is the change risky?]: no
[Why is the change risky/not risky?]: small css changes
[String changes made/needed]:

Comment 11

[Gerry Chang [:gchang]]

Comment on attachment 8933382 [details]
Bug 1415665 - Very long domain names overflow from the Highlight borders.

Fix a long domain name overflow issue. Beta58+.

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/acde061a6109