1415707 - about:accounts is still accepted as a valid address but fails to load anything

Status: VERIFIED FIXED

(Firefox :: Sync, defect)

Description

[Mark Hammond [:markh] [:mhammond]]

STR:
* Type about:accounts into the url bar and press enter.

Expected:
* Since bug 1395460 landed, a page indicating the address is not valid.

Actual:
* A spinner throbs indefinitely and nothing is loaded.

This *might* just be removing http://searchfox.org/mozilla-central/rev/c99d035f00dd894feff38e4ad28a73fb679c63a6/browser/components/build/nsModule.cpp#108

Comment 1

[Edouard Oger [:eoger]]

Attachment: Bug 1415707 - Remove about:accounts redirector.

Review commit: https://reviewboard.mozilla.org/r/197854/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/197854/

Comment 2

[Edouard Oger [:eoger]]

Tested with a full build, thanks!

Comment 3

[Mark Hammond [:markh] [:mhammond]]

Comment on attachment 8926626 [details]
Bug 1415707 - Remove about:accounts redirector.

https://reviewboard.mozilla.org/r/197854/#review203128

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7ae07e7920fe
Remove about:accounts redirector. r=markh

Comment 5

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/7ae07e7920fe

Comment 6

[Sajedul Islam]

I have reproduced this bug with Nightly 58.0a1 (2017-11-08) on Windows 8.1 , 64 Bit ! 

This bug's fix is Verified with latest beta !

Build   ID    20171115114231
User Agent    Mozilla/5.0 (Windows NT 6.3; Win64; x64; rv:58.0) Gecko/20100101 Firefox/58.0

Comment 7

[Mohammad Maruf Rahman]

I have reproduced this bug with Nightly 58.0a1 (2017-11-08) on Ubuntu 12.04 (64 Bit) LTS!
This bug's fix is Verified with latest beta !

Build   ID    20171120142222
User Agent    Mozilla/5.0 (X11; Linux x86_64; rv:58.0) Gecko/20100101 Firefox/58.0

[bugday-20171115]

Comment 8

[Mark Hammond [:markh] [:mhammond]]

thanks!