1415716 - Remove nsIDOMHTMLOptionElement

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement)

Description

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Continuing post-addon-deprecation XPCOM interface cleanup.

Comment 1

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Attachment: Bug 1415716 - Remove nsIDOMHTMLOptionElement;

Review commit: https://reviewboard.mozilla.org/r/197932/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/197932/

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8926687 [details]
Bug 1415716 - Remove nsIDOMHTMLOptionElement;

https://reviewboard.mozilla.org/r/197932/#review203150

r=me.  Thank you!

::: layout/forms/nsListControlFrame.cpp:233
(Diff revision 1)
>      fRect.MoveBy(containerFrame->GetOffsetTo(this));
>    }
>    fRect += aPt;
>  
>    bool lastItemIsSelected = false;
>    if (focusedContent) {

Could nix this check and just use FromContentOrNull.

Comment 3

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Comment on attachment 8926687 [details]
Bug 1415716 - Remove nsIDOMHTMLOptionElement;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/197932/diff/1-2/

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ea33d0050243
Remove nsIDOMHTMLOptionElement; r=bz

Comment 5

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/ea33d0050243