1415718 - Uninitialized version warning in ssl3_SendClientHello

Status: RESOLVED FIXED

(NSS :: Libraries, defect)

Description

[Martin Thomson [:mt:]]

Attachment: Fix that I'll put on phab too

Gecko builds use a different set of warning flags, and aside from signed/unsigned comparison warnings (of which we still have many), they throw out this.


 0:03.26 .../mozilla-inbound/security/nss/lib/ssl/ssl3con.c: In function ‘ssl3_SendClientHello’:
 0:03.26 .../mozilla-inbound/security/nss/lib/ssl/ssl3con.c:5224:69: warning: ‘version’ may be used uninitialized in this function [-Wmaybe-uninitialized]
 0:03.26      fallbackSCSV = ss->opt.enableFallbackSCSV && (!requestingResume ||
 0:03.26                                                   ~~~~~~~~~~~~~~~~~~~^~
 0:03.26                                                    version < sid->version);
 0:03.26                                                    ~~~~~~~~~~~~~~~~~~~~~~~

This is actually wrong.  The test is never run with an uninitialized `version`, but if you look at the code, you can appreciate why the compiler has trouble recognizing this.

Better to initialize the value properly from the outset and use the various tests throughout the function to drive the value downwards.

Comment 1

[Phabricator Automation]

Comment on attachment 8926609 [details]
Bug 1415718 - Initialize version in ssl3_SendClientHello, r?ttaubert

Tim Taubert [:ttaubert] has approved the revision.

https://phabricator.services.mozilla.com/D208#5189

Comment 2

[Martin Thomson [:mt:]]

https://hg.mozilla.org/projects/nss/rev/5b6c6551931f46228c82285dec1969687f9dd47a