Closed Bug 1415728 Opened 3 years ago Closed 3 years ago

Change selected row on keydown instead of on keyup

Categories

(DevTools :: JSON Viewer, defect)

58 Branch
defect
Not set
normal

Tracking

(firefox58 verified)

VERIFIED FIXED
Firefox 58
Tracking Status
firefox58 --- verified

People

(Reporter: Oriol, Assigned: Oriol)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Load https://api.github.com
Click some row to select it
Keep an arrow key pressed

Expected: the selected row keeps changing
Result: it doesn't change until you release the key

This is so annoying when you want to scroll using the keyboard, it forces you to keep pressing and releasing the arrow key.
Comment on attachment 8926640 [details]
Bug 1415728 - Change JSON Viewer's selected row on keydown instead of on keyup.

https://reviewboard.mozilla.org/r/197872/#review203346

Very nice!

Just one inline comment

Thanks for the patch!

Honza

::: devtools/client/jsonview/test/browser_jsonview_row_selection.js:41
(Diff revision 1)
>    yield BrowserTestUtils.synthesizeKey("VK_UP", {}, tab.linkedBrowser);
>    yield assertRowSelected(1);
>    is(yield evalInContent("scroller.scrollTop"), 0, "Scrolled to the top.");
>  });
>  
> +add_task(function* () {

You can use async fucntion (generators is the old school way)
Attachment #8926640 - Flags: review?(odvarko) → review+
Comment on attachment 8926640 [details]
Bug 1415728 - Change JSON Viewer's selected row on keydown instead of on keyup.

https://reviewboard.mozilla.org/r/197872/#review203346

> You can use async fucntion (generators is the old school way)

Thanks, I thought add_task wanted a generator
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/07b7f8df735e
Change JSON Viewer's selected row on keydown instead of on keyup. r=Honza
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/07b7f8df735e
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
QA Whiteboard: [good first verify]
I have reproduced this bug with Nightly 58.0a1 (2017-11-08) on Windows 10, 64 Bit!

This bug's fix is verified with latest Beta!

Build ID   : 20171114032831
User Agent : Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:58.0) Gecko/20100101 Firefox/58.0
QA Whiteboard: [good first verify] → [good first verify] [testday-20171117]
I also can confirm that 58.0b4 (20171115114231) build is verified fixed on Ubuntu 14.04 x86 and macOS 10.13, too. 
Thank you Mohammad Maruf Rahman for you testing efforts!
Status: RESOLVED → VERIFIED
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.