1415728 - Change selected row on keydown instead of on keyup

Status: VERIFIED FIXED

(DevTools :: JSON Viewer, defect)

Description

[Oriol Brufau [:Oriol]]

Load https://api.github.com
Click some row to select it
Keep an arrow key pressed

Expected: the selected row keeps changing
Result: it doesn't change until you release the key

This is so annoying when you want to scroll using the keyboard, it forces you to keep pressing and releasing the arrow key.

Comment 1

[Oriol Brufau [:Oriol]]

Attachment: Bug 1415728 - Change JSON Viewer's selected row on keydown instead of on keyup.

Review commit: https://reviewboard.mozilla.org/r/197872/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/197872/

Comment 2

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Comment on attachment 8926640 [details]
Bug 1415728 - Change JSON Viewer's selected row on keydown instead of on keyup.

https://reviewboard.mozilla.org/r/197872/#review203346

Very nice!

Just one inline comment

Thanks for the patch!

Honza

::: devtools/client/jsonview/test/browser_jsonview_row_selection.js:41
(Diff revision 1)
>    yield BrowserTestUtils.synthesizeKey("VK_UP", {}, tab.linkedBrowser);
>    yield assertRowSelected(1);
>    is(yield evalInContent("scroller.scrollTop"), 0, "Scrolled to the top.");
>  });
>  
> +add_task(function* () {

You can use async fucntion (generators is the old school way)

Comment 3

[Oriol Brufau [:Oriol]]

Comment on attachment 8926640 [details]
Bug 1415728 - Change JSON Viewer's selected row on keydown instead of on keyup.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/197872/diff/1-2/

Comment 4

[Oriol Brufau [:Oriol]]

Comment on attachment 8926640 [details]
Bug 1415728 - Change JSON Viewer's selected row on keydown instead of on keyup.

https://reviewboard.mozilla.org/r/197872/#review203346

> You can use async fucntion (generators is the old school way)

Thanks, I thought add_task wanted a generator

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/07b7f8df735e
Change JSON Viewer's selected row on keydown instead of on keyup. r=Honza

Comment 6

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/07b7f8df735e

Comment 7

[Mohammad Maruf Rahman]

I have reproduced this bug with Nightly 58.0a1 (2017-11-08) on Windows 10, 64 Bit!

This bug's fix is verified with latest Beta!

Build ID   : 20171114032831
User Agent : Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:58.0) Gecko/20100101 Firefox/58.0

Comment 8

[Iulia Cristescu, QA [:JuliaC] (away, please needinfo? [e-mail])]

I also can confirm that 58.0b4 (20171115114231) build is verified fixed on Ubuntu 14.04 x86 and macOS 10.13, too. 
Thank you Mohammad Maruf Rahman for you testing efforts!