Closed
Bug 1415789
Opened 7 years ago
Closed 4 years ago
-moz-appearance button-bevel should behave like -webkit-appearance: button-bevel
Categories
(Core :: Layout: Form Controls, enhancement, P3)
Core
Layout: Form Controls
Tracking
()
RESOLVED
FIXED
Webcompat Priority | P3 |
People
(Reporter: lochang, Assigned: lochang)
References
(Blocks 1 open bug)
Details
(Whiteboard: [webkitcompat] [webcompat])
Attachments
(1 file)
6.40 KB,
patch
|
Details | Diff | Splinter Review |
According to comment 30 in bug 1368555, we should rename current button-bevel to square-button then implement new button-bevel which behaves like Chrome's button-bevel.
Updated•7 years ago
|
Priority: -- → P3
Comment 1•5 years ago
|
||
zcorpan's httparchive report on -moz-appearance / -webkit-appearance usage, at https://gist.github.com/zcorpan/499ee4e1f8f1a60f13e0fe43bcfb7fdf indicates that 'button-bevel' is very rarely used in the wild. I wonder if we could simply remove this value?
Comment 2•5 years ago
|
||
Fwiw, we only parse 'button-bevel' as a valid value but then essentially treat it as 'none' internally on all platforms, except OSX where it maps to some "kThemeMediumBevelButton" native theme type: https://searchfox.org/mozilla-central/search?q=ButtonBevel https://searchfox.org/mozilla-central/source/widget/cocoa/nsNativeThemeCocoa.mm#1735
Comment 3•5 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=befefb37c1e3ebdd4896d012b7448aba7e2566ce https://treeherder.mozilla.org/#/jobs?repo=try&revision=da2f633935dfeb7c734e5193fd43791c6a8822e6
Updated•5 years ago
|
Attachment #9025854 -
Attachment description: WIP → WIP - remove 'button-bevel'
Comment 4•5 years ago
|
||
Fwiw, I queried https://webcompat.com/ for "button-bevel" and got zero results: https://webcompat.com/issues?page=1&per_page=50&state=open&stage=all&sort=created&direction=desc&q=button-bevel
Comment 5•5 years ago
|
||
Migrating Webcompat whiteboard priorities to project flags. See bug 1547409.
Webcompat Priority: --- → ?
Comment 6•5 years ago
|
||
See bug 1547409. Migrating whiteboard priority tags to program flags.
Comment 7•5 years ago
|
||
Chromium has removed button-bevel in M75. See bug 1554150
Updated•4 years ago
|
Webcompat Priority: ? → P3
Comment 8•4 years ago
|
||
Didn't see this bug until now. I just removed this value in bug 1650256.
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•