Closed Bug 1415800 Opened 2 years ago Closed 2 years ago

EditorBase::GetPriorNode(), EditorBase::GetNextNode(), HTMLEditor::GetPriorHTMLNode(), HTMLEditor::GetNextHTMLNode() should use EditorRawDOMPoint

Categories

(Core :: Editor, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla58
Tracking Status
firefox58 --- fixed

People

(Reporter: masayuki, Assigned: masayuki)

References

Details

Attachments

(5 files)

Comment on attachment 8927129 [details]
Bug 1415800 - part 1: Redesign EditorBase::GetPriorNode() with EditorRawDOMPoint

https://reviewboard.mozilla.org/r/198354/#review203656
Attachment #8927129 - Flags: review?(m_kato) → review+
Comment on attachment 8927129 [details]
Bug 1415800 - part 1: Redesign EditorBase::GetPriorNode() with EditorRawDOMPoint

https://reviewboard.mozilla.org/r/198354/#review203662
Comment on attachment 8927130 [details]
Bug 1415800 - part 2: Redesign EditorBase::GetNextNode() with EditorRawDOMPoint

https://reviewboard.mozilla.org/r/198356/#review203666
Attachment #8927130 - Flags: review?(m_kato) → review+
Comment on attachment 8927131 [details]
Bug 1415800 - part 3: Redesign HTMLEditor::GetPriorHTMLNode() as similar to EditorBase::GetPrevious*()

https://reviewboard.mozilla.org/r/198358/#review203668
Attachment #8927131 - Flags: review?(m_kato) → review+
Comment on attachment 8927132 [details]
Bug 1415800 - part 4: Redesign HTMLEditor::GetNextHTMLNode() same as  similar to EditorBase::GetNext*()

https://reviewboard.mozilla.org/r/198360/#review203680
Attachment #8927132 - Flags: review?(m_kato) → review+
Comment on attachment 8927133 [details]
Bug 1415800 - part 5: Redesign HTMLEditRules::FindNearSelectableNode()

https://reviewboard.mozilla.org/r/198362/#review203686
Attachment #8927133 - Flags: review?(m_kato) → review+
Pushed by masayuki@d-toybox.com:
https://hg.mozilla.org/integration/autoland/rev/d8aab8a9a0f7
part 1: Redesign EditorBase::GetPriorNode() with EditorRawDOMPoint r=m_kato
https://hg.mozilla.org/integration/autoland/rev/5a622e094403
part 2: Redesign EditorBase::GetNextNode() with EditorRawDOMPoint r=m_kato
https://hg.mozilla.org/integration/autoland/rev/ed0dad4054fa
part 3: Redesign HTMLEditor::GetPriorHTMLNode() as similar to EditorBase::GetPrevious*() r=m_kato
https://hg.mozilla.org/integration/autoland/rev/682cda40a859
part 4: Redesign HTMLEditor::GetNextHTMLNode() same as  similar to EditorBase::GetNext*() r=m_kato
https://hg.mozilla.org/integration/autoland/rev/459541207265
part 5: Redesign HTMLEditRules::FindNearSelectableNode() r=m_kato
You need to log in before you can comment on or make changes to this bug.