Closed Bug 1415811 Opened 7 years ago Closed 7 years ago

.mozconfig: line 3: /builds/slave/c-cen-t-lnx-dbg/build/mozilla/suite/config/mozconfigs/common: No such file or directory

Categories

(SeaMonkey :: Build Config, defect)

Product:
SeaMonkey
Component:
Build Config
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
seamonkey2.55

People

(Reporter: ewong, Assigned: ewong)

Details

Attachments

(2 files, 2 obsolete files)

[mozconfigs] proposed patch for nightly only. w/ fixes
5.46 KB, patch
ewong
: review+
Details | Diff | Splinter Review
[mozconfigs] fixed proposed patch
20.33 KB, patch
frg
: review+
Details | Diff | Splinter Review 
At the beginning there's also an error:

Starting 'mach python-test' with -j4
Error loading mozconfig: /builds/slave/c-cen-t-lnx-dbg/build/.mozconfig

Evaluation of your mozconfig exited with an error. This could be triggered
by a command inside your mozconfig failing. Please change your mozconfig
to not error and/or to catch errors in executed commands.

mozconfig output:

------BEGIN_MK_OPTION
AUTOCLOBBER=1
------END_MK_OPTION
------BEGIN_AC_OPTION
--enable-crashreporter
------END_AC_OPTION
------BEGIN_AC_OPTION
--enable-js-shell
------END_AC_OPTION
------BEGIN_MK_OPTION
export MOZ_AUTOMATION_BUILD_SYMBOLS=1
------END_MK_OPTION
------BEGIN_MK_OPTION
export MOZ_AUTOMATION_L10N_CHECK=1
------END_MK_OPTION
------BEGIN_MK_OPTION
export MOZ_AUTOMATION_PACKAGE=1
------END_MK_OPTION
------BEGIN_MK_OPTION
export MOZ_AUTOMATION_PACKAGE_TESTS=1
------END_MK_OPTION
------BEGIN_MK_OPTION
export MOZ_AUTOMATION_INSTALLER=0
------END_MK_OPTION
------BEGIN_MK_OPTION
export MOZ_AUTOMATION_UPDATE_PACKAGING=0
------END_MK_OPTION
------BEGIN_MK_OPTION
export MOZ_AUTOMATION_PACKAGE_GENERATED_SOURCES=1
------END_MK_OPTION
------BEGIN_MK_OPTION
export MOZ_AUTOMATION_UPLOAD=1
------END_MK_OPTION
------BEGIN_MK_OPTION
export MOZ_AUTOMATION_UPLOAD_SYMBOLS=0
------END_MK_OPTION
------BEGIN_AC_OPTION
--enable-rust-simd
------END_AC_OPTION
------BEGIN_MK_OPTION
PATH=/builds/slave/c-cen-t-lnx-dbg/build/gcc/bin:/tools/buildbot/bin:/usr/local/bin:/usr/lib/ccache:/bin:/usr/bin:/usr/local/sbin:/usr/sbin:/sbin:/tools/git/bin:/tools/python27/bin:/tools/python27-mercurial/bin:/home/cltbld/bin
------END_MK_OPTION
------BEGIN_AC_OPTION
--enable-elf-hack
------END_AC_OPTION
------BEGIN_AC_OPTION
--enable-stdcxx-compat
------END_AC_OPTION
------BEGIN_MK_OPTION
export LD_LIBRARY_PATH=objdir/mozilla/dist/bin:/builds/slave/c-cen-t-lnx-dbg/build/gcc/lib64:/builds/slave/c-cen-t-lnx-dbg/build/gcc/lib:/builds/slave/c-cen-t-lnx-dbg/build/gtk3/usr/local/lib:/builds/slave/c-cen-t-lnx-dbg/build/gcc/lib64:/builds/slave/c-cen-t-lnx-dbg/build/gcc/lib
------END_MK_OPTION
------BEGIN_AC_OPTION
--enable-default-toolkit=cairo-gtk3
------END_AC_OPTION
------BEGIN_MK_OPTION
export FONTCONFIG_PATH=/builds/slave/c-cen-t-lnx-dbg/build/gtk3/usr/local/etc/fonts
------END_MK_OPTION
------BEGIN_MK_OPTION
export PANGO_SYSCONFDIR=/builds/slave/c-cen-t-lnx-dbg/build/gtk3/usr/local/etc
------END_MK_OPTION
------BEGIN_MK_OPTION
export PANGO_LIBDIR=/builds/slave/c-cen-t-lnx-dbg/build/gtk3/usr/local/lib
------END_MK_OPTION
------BEGIN_MK_OPTION
export GDK_PIXBUF_MODULE_FILE=/builds/slave/c-cen-t-lnx-dbg/build/gtk3/usr/local/lib/gdk-pixbuf-2.0/2.10.0/loaders.cache
------END_MK_OPTION
------BEGIN_MK_OPTION
export GDK_PIXBUF_MODULEDIR=/builds/slave/c-cen-t-lnx-dbg/build/gtk3/usr/local/lib/gdk-pixbuf-2.0/2.10.0/loaders
------END_MK_OPTION
------BEGIN_MK_OPTION
export LD_LIBRARY_PATH=objdir/mozilla/dist/bin:/builds/slave/c-cen-t-lnx-dbg/build/gcc/lib64:/builds/slave/c-cen-t-lnx-dbg/build/gcc/lib:/builds/slave/c-cen-t-lnx-dbg/build/gtk3/usr/local/lib:/builds/slave/c-cen-t-lnx-dbg/build/gcc/lib64:/builds/slave/c-cen-t-lnx-dbg/build/gcc/lib:/builds/slave/c-cen-t-lnx-dbg/build/gtk3/usr/local/lib
------END_MK_OPTION
------BEGIN_MK_OPTION
CONFIG_GUESS=i686-pc-linux
------END_MK_OPTION
------BEGIN_AC_OPTION
--target=i686-pc-linux
------END_AC_OPTION
------BEGIN_AC_OPTION
--host=i686-pc-linux
------END_AC_OPTION
------BEGIN_AC_OPTION
--x-libraries=/usr/lib
------END_AC_OPTION
/builds/slave/c-cen-t-lnx-dbg/build/.mozconfig: line 3: /builds/slave/c-cen-t-lnx-dbg/build/mozilla/suite/config/mozconfigs/common: No such file or directory
make: *** [check] Error 1

And I think it's this that's the problem.  

looking at our .mozconfig, we use $topsrcdir and like everytime we use that variable, we're
screwed up as it would (during the build process) assume topsrcdir == ./mozilla instead of ./

[this bug was spun off from bug 1415803]

        Attachment #8927823 -
        Flags: review?(frgrahl)

    
    

    
  
Comment on attachment 8927823 [details] [diff] [review]
[mozconfigs] proposed patch for nightly only.

r+ with path fixed: $topsrcdir/$commreltopsrcdir

See bug 1366607

        Attachment #8927823 -
        Flags: review?(frgrahl) → review+

    
    

    
  


  
Assignee: nobody → ewong

        Attachment #8927823 -
        Attachment is obsolete: true
Status: NEW → ASSIGNED

        Attachment #8927832 -
        Flags: review+

    
    

    
  
Pushed by ewong@pw-wspx.org:
https://hg.mozilla.org/comm-central/rev/f57390a5d6dd
Use TOOLTOOL_DIR if defined, else topsrcdir/commreltopsrcdir. r=frg
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED

    
  
Status: RESOLVED → REOPENED
Resolution: FIXED → ---

    
    

    
  


  
Rationale.

$commreltopsrcdir is defined in $topsrcdir/build/mozconfig.comm-support,
so having  TOOLTOOL_DIR=${TOOLTOOL_DIR:-$topsrcdir/$commreltopsrcdir}
at the top isn't going to work. (It's just lucky that TOOLTOOL_DIR is
defined in Linux32.. otherwise, it'd still have been busted).

since $topsrcdir/build/mozconfig.comm-support *always* exists since it's
also in ./mozilla/build, therefore it is safe to use
$topsrcdir/build/mozconfig.comm-support at the top of all the mozconfigs.
It's the others that are questionable and particularly problematic
are the ones with suite/ in. 

Therefore this patch ensures using TOOLTOOL_DIR (or topsrcdir/commreltopsrcdir)
for the rest of the paths.

        Attachment #8928040 -
        Flags: review?(frgrahl)

    
    

    
  
Comment on attachment 8928040 [details] [diff] [review]
[mozconfigs] proposed updated patch

NIT . "$topsrcdir/build/mozconfig.comm-support" is not always on the top.

Could you check that the order is always the same. Makes fixing and comparing them easier.

Otherwise LGTM

        Attachment #8928040 -
        Flags: review?(frgrahl) → review+

    
    

    
  


  

        Attachment #8928040 -
        Attachment is obsolete: true

        Attachment #8928098 -
        Flags: review?(frgrahl)

        Attachment #8928098 -
        Flags: review?(frgrahl) → review+

    
    

    
  
Pushed by ewong@pw-wspx.org:
https://hg.mozilla.org/comm-central/rev/0261a2ac5448
use TOOLTOOL_DIR (if it exists in the env) otherwise use $topsrcdir/$commreltopsrcdir r=frg
Status: REOPENED → RESOLVED
Closed: 7 years ago → 7 years ago
Resolution: --- → FIXED

    
    

    
  
Target should be changed to 2.56 when the value is added.
Target Milestone: --- → seamonkey2.55

    
    

    
  
Comment on attachment 8927832 [details] [diff] [review]
[mozconfigs] proposed patch for nightly only. w/ fixes

this patch needs to be transplanted to c-b.

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: