Integrate gfxCriticalNote/gfxCriticalError for WebRender in gpu process

RESOLVED FIXED in mozilla58

Status

()

enhancement
P1
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: jerry, Assigned: jerry)

Tracking

(Blocks 1 bug)

unspecified
mozilla58
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox57 unaffected, firefox58 unaffected)

Details

(Whiteboard: [wr-reserve])

Attachments

(1 attachment, 1 obsolete attachment)

+++ This bug was initially created as a clone of Bug #1399389 +++

In bug 1399389, the wr error/warn! log could be redirected to gfxCriticalNote/Error. But that initialization code doesn't used in gpu process. We still can't see the gfx log in gpu process. This bug try to do the similar things for gpu process.
MozReview-Commit-ID: 3Mey7XRYRn6
Attachment #8926791 - Flags: review?(bugmail)
Comment on attachment 8926791 [details] [diff] [review]
integrate gfxCriticalNote/gfxCriticalError for WebRender in gpu process.

Review of attachment 8926791 [details] [diff] [review]:
-----------------------------------------------------------------

I like that you put the init/cleanup stuff next to the wr::RenderThread init/cleanup in GPUParent. For consistency, can we also do the same for the UI-process equivalent? That is, instead of putting the code in gfxPlatform::InitWebRenderConfig, can we instead put it next to http://searchfox.org/mozilla-central/rev/c99d035f00dd894feff38e4ad28a73fb679c63a6/gfx/thebes/gfxPlatform.cpp#1043 ? Similar for shutdown, can we put it in ShutdownLayersIPC?

::: gfx/webrender_bindings/WebRenderAPI.cpp
@@ +138,5 @@
>    layers::SynchronousTask* mTask;
>  };
>  
> +//static
> +void

for consistency with other places, do:
/*static*/ void

@@ +147,5 @@
> +  mozilla::wr::wr_init_external_log_handler(wr::LogLevelFilter::Error);
> +}
> +
> +//static
> +void

ditto
Whiteboard: [wr-reserve]
Call the init() call before the renderThread::start(), and call the shutdown() after the renderThread::shutdown().
The content process could call some WR related functions, so I also need to redirect the log to gecko for content process.
Attachment #8927119 - Flags: review?(bugmail)
Attachment #8926791 - Attachment is obsolete: true
Attachment #8926791 - Flags: review?(bugmail)
Comment on attachment 8927119 [details] [diff] [review]
integrate gfxCriticalNote/gfxCriticalError for WebRender in gpu process. v2

Review of attachment 8927119 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, thanks!
Attachment #8927119 - Flags: review?(bugmail) → review+
Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/14c25243ff09
integrate gfxCriticalNote/gfxCriticalError for WebRender in gpu process. r=kats
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/14c25243ff09
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in before you can comment on or make changes to this bug.