1415816 - Integrate gfxCriticalNote/gfxCriticalError for WebRender in gpu process

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement, P1)

Description

[Jerry Shih[:jerry] (UTC+8) (inactive)]

+++ This bug was initially created as a clone of Bug #1399389 +++

In bug 1399389, the wr error/warn! log could be redirected to gfxCriticalNote/Error. But that initialization code doesn't used in gpu process. We still can't see the gfx log in gpu process. This bug try to do the similar things for gpu process.

Comment 1

[Jerry Shih[:jerry] (UTC+8) (inactive)]

Attachment: integrate gfxCriticalNote/gfxCriticalError for WebRender in gpu process.

MozReview-Commit-ID: 3Mey7XRYRn6

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8926791 [details] [diff] [review]
integrate gfxCriticalNote/gfxCriticalError for WebRender in gpu process.

Review of attachment 8926791 [details] [diff] [review]:
-----------------------------------------------------------------

I like that you put the init/cleanup stuff next to the wr::RenderThread init/cleanup in GPUParent. For consistency, can we also do the same for the UI-process equivalent? That is, instead of putting the code in gfxPlatform::InitWebRenderConfig, can we instead put it next to http://searchfox.org/mozilla-central/rev/c99d035f00dd894feff38e4ad28a73fb679c63a6/gfx/thebes/gfxPlatform.cpp#1043 ? Similar for shutdown, can we put it in ShutdownLayersIPC?

::: gfx/webrender_bindings/WebRenderAPI.cpp
@@ +138,5 @@
>    layers::SynchronousTask* mTask;
>  };
>  
> +//static
> +void

for consistency with other places, do:
/*static*/ void

@@ +147,5 @@
> +  mozilla::wr::wr_init_external_log_handler(wr::LogLevelFilter::Error);
> +}
> +
> +//static
> +void

ditto

Comment 3

[Jerry Shih[:jerry] (UTC+8) (inactive)]

Attachment: integrate gfxCriticalNote/gfxCriticalError for WebRender in gpu process. v2

Call the init() call before the renderThread::start(), and call the shutdown() after the renderThread::shutdown().
The content process could call some WR related functions, so I also need to redirect the log to gecko for content process.

Comment 4

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8927119 [details] [diff] [review]
integrate gfxCriticalNote/gfxCriticalError for WebRender in gpu process. v2

Review of attachment 8927119 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, thanks!

Comment 5

[Jerry Shih[:jerry] (UTC+8) (inactive)]

try:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=3ed7f1a9c85c07611c118c87f947bef9a27dfec9

Comment 6

[Jerry Shih[:jerry] (UTC+8) (inactive)]

Please land the attachment 8927119 [details] [diff] [review] to m-c.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/14c25243ff09
integrate gfxCriticalNote/gfxCriticalError for WebRender in gpu process. r=kats

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/14c25243ff09