1415830 - Back and forward button "cmd + [" and "cmd + ]" do not work with wireless keyboard

Status: VERIFIED FIXED

(Firefox for iOS :: General, defect, P3)

Description

[Simon Basca [:SimonB]]

Build: 10.0 (7617)
Device: iPad mini 4
iOS: 11.1

Steps to reproduce:
1. Go to google.com
2. Press "cmd + [" to go back from google.com

Actual results:
- Nothing happens.

Expected results:
- Should be directed to about:home.

Note: 
- This works fine in Safari. 
- The same issue occurs when going forward by pressing "cmd + ]"

Comment 1

[Farhan Patel [:farhan]]

Renaming the selectors seems to work. I dont know why!

Comment 2

[:garvan]

Renaming works, the selector lookup seems like it is confused by other uses of the function named goBack(), even though the code uses BrowserViewController.goBack explicitly.

Comment 3

[:garvan]

Attachment: Pull request

I didn't spend much time on digging into this, but I am not opposed to digging deeper if needed. I tested most of the shortcuts with an actual iPad + keyboard.

Comment 4

[:garvan]

landed on master and v10.x

Comment 5

[Simon Basca [:SimonB]]

Verifying as fix on beta 10.3(7934)