1415835 - Convert some more xpcshell-tests in toolkit/components/places/tests/bookmarks to Bookmarks.jsm API

Status: RESOLVED FIXED

(Toolkit :: Places, enhancement)

Description

[Mark Banner (:standard8)]

As part of the continuing switch to use async APIs, I've transitioned some more of the tests in the bookmarks directory to use the async APIs.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1415835 - Convert xpcshell-tests in toolkit/components/places/tests/bookmarks to Bookmarks.jsm API.

Review commit: https://reviewboard.mozilla.org/r/198050/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/198050/

Comment 2

[Marco Bonardo [:mak]]

Comment on attachment 8926797 [details]
Bug 1415835 - Convert xpcshell-tests in toolkit/components/places/tests/bookmarks to Bookmarks.jsm API.

https://reviewboard.mozilla.org/r/198050/#review203308

::: toolkit/components/places/tests/bookmarks/test_458683.js:69
(Diff revision 1)
> -    tagRoot.containerOpen = false;
> +  tagRoot.containerOpen = false;
>  
> -    // add a separator and a folder inside tag folder
> +  // add a separator and a folder inside tag folder
> -    PlacesUtils.bookmarks.insertSeparator(this._tagItemId,
> +  PlacesUtils.bookmarks.insertSeparator(tagItemId,
> -                                         PlacesUtils.bookmarks.DEFAULT_INDEX);
> +                                       PlacesUtils.bookmarks.DEFAULT_INDEX);
> -    PlacesUtils.bookmarks.createFolder(this._tagItemId,
> +  PlacesUtils.bookmarks.createFolder(tagItemId,

There are an insertSeparator and a createFolder not converted?

::: toolkit/components/places/tests/bookmarks/test_458683.js:76
(Diff revision 1)
> -                                       PlacesUtils.bookmarks.DEFAULT_INDEX);
> +                                     PlacesUtils.bookmarks.DEFAULT_INDEX);
>  
> -    // add a separator and a folder inside tag root
> +  // add a separator and a folder inside tag root
> -    PlacesUtils.bookmarks.insertSeparator(PlacesUtils.bookmarks.tagsFolder,
> +  PlacesUtils.bookmarks.insertSeparator(PlacesUtils.bookmarks.tagsFolder,
> -                                          PlacesUtils.bookmarks.DEFAULT_INDEX);
> +                                        PlacesUtils.bookmarks.DEFAULT_INDEX);
> -    PlacesUtils.bookmarks.createFolder(PlacesUtils.bookmarks.tagsFolder,
> +  PlacesUtils.bookmarks.createFolder(PlacesUtils.bookmarks.tagsFolder,

ditto

::: toolkit/components/places/tests/bookmarks/test_savedsearches.js:188
(Diff revision 1)
>        do_check_eq(node.childCount, 1);
>        node.containerOpen = false;
>      }
>  
>      // test live-update of moved queries
> -    var tmpFolderId = PlacesUtils.bookmarks.createFolder(
> +    // XXX

leftover?

Comment 3

[Mark Banner (:standard8)]

Comment on attachment 8926797 [details]
Bug 1415835 - Convert xpcshell-tests in toolkit/components/places/tests/bookmarks to Bookmarks.jsm API.

https://reviewboard.mozilla.org/r/198050/#review203308

> There are an insertSeparator and a createFolder not converted?

Per irc I'm leaving these as they are for now - the new apis don't allow insertion of separators/folders into the tag folders.

I will add a comment though.

Comment 4

[Mark Banner (:standard8)]

Comment on attachment 8926797 [details]
Bug 1415835 - Convert xpcshell-tests in toolkit/components/places/tests/bookmarks to Bookmarks.jsm API.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/198050/diff/1-2/

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cf6c386ae59c
Convert xpcshell-tests in toolkit/components/places/tests/bookmarks to Bookmarks.jsm API. r=mak

Comment 6

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/cf6c386ae59c