Closed Bug 1415835 Opened 4 years ago Closed 4 years ago

Convert some more xpcshell-tests in toolkit/components/places/tests/bookmarks to Bookmarks.jsm API

Categories

(Toolkit :: Places, enhancement)

Product:
Toolkit
Component:
Places
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla58
Tracking Flags:
Tracking Status
firefox58 --- fixed

People

(Reporter: standard8, Assigned: standard8)

References

Details

(Whiteboard: [fxsearch])

Attachments

(1 file)

Bug 1415835 - Convert xpcshell-tests in toolkit/components/places/tests/bookmarks to Bookmarks.jsm API.
59 bytes, text/x-review-board-request
mak
: review+
Details 
As part of the continuing switch to use async APIs, I've transitioned some more of the tests in the bookmarks directory to use the async APIs.
Comment on attachment 8926797 [details]
Bug 1415835 - Convert xpcshell-tests in toolkit/components/places/tests/bookmarks to Bookmarks.jsm API.

https://reviewboard.mozilla.org/r/198050/#review203308

::: toolkit/components/places/tests/bookmarks/test_458683.js:69
(Diff revision 1)
> -    tagRoot.containerOpen = false;
> +  tagRoot.containerOpen = false;
>  
> -    // add a separator and a folder inside tag folder
> +  // add a separator and a folder inside tag folder
> -    PlacesUtils.bookmarks.insertSeparator(this._tagItemId,
> +  PlacesUtils.bookmarks.insertSeparator(tagItemId,
> -                                         PlacesUtils.bookmarks.DEFAULT_INDEX);
> +                                       PlacesUtils.bookmarks.DEFAULT_INDEX);
> -    PlacesUtils.bookmarks.createFolder(this._tagItemId,
> +  PlacesUtils.bookmarks.createFolder(tagItemId,

There are an insertSeparator and a createFolder not converted?

::: toolkit/components/places/tests/bookmarks/test_458683.js:76
(Diff revision 1)
> -                                       PlacesUtils.bookmarks.DEFAULT_INDEX);
> +                                     PlacesUtils.bookmarks.DEFAULT_INDEX);
>  
> -    // add a separator and a folder inside tag root
> +  // add a separator and a folder inside tag root
> -    PlacesUtils.bookmarks.insertSeparator(PlacesUtils.bookmarks.tagsFolder,
> +  PlacesUtils.bookmarks.insertSeparator(PlacesUtils.bookmarks.tagsFolder,
> -                                          PlacesUtils.bookmarks.DEFAULT_INDEX);
> +                                        PlacesUtils.bookmarks.DEFAULT_INDEX);
> -    PlacesUtils.bookmarks.createFolder(PlacesUtils.bookmarks.tagsFolder,
> +  PlacesUtils.bookmarks.createFolder(PlacesUtils.bookmarks.tagsFolder,

ditto

::: toolkit/components/places/tests/bookmarks/test_savedsearches.js:188
(Diff revision 1)
>        do_check_eq(node.childCount, 1);
>        node.containerOpen = false;
>      }
>  
>      // test live-update of moved queries
> -    var tmpFolderId = PlacesUtils.bookmarks.createFolder(
> +    // XXX

leftover?
Attachment #8926797 - Flags: review?(mak77) → review+
Comment on attachment 8926797 [details]
Bug 1415835 - Convert xpcshell-tests in toolkit/components/places/tests/bookmarks to Bookmarks.jsm API.

https://reviewboard.mozilla.org/r/198050/#review203308

> There are an insertSeparator and a createFolder not converted?

Per irc I'm leaving these as they are for now - the new apis don't allow insertion of separators/folders into the tag folders.

I will add a comment though.
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/cf6c386ae59c
Convert xpcshell-tests in toolkit/components/places/tests/bookmarks to Bookmarks.jsm API. r=mak
https://hg.mozilla.org/mozilla-central/rev/cf6c386ae59c
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox58: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in before you can comment on or make changes to this bug.