1415836 - [Form Autofill] The text in autocomplete footer wraps incorrectly

Status: VERIFIED FIXED

(Toolkit :: Form Autofill, defect, P3)

Description

[Luke Chang [:lchang] (inactive)]

Attachment: screenshot.png

Please see the attachment. It only happens when the width of the dropdown is 151px or 152px.

It's a regression cased by bug 1409250.

Comment 1

[Ray Lin[:ralin]]

Attachment: with text-align: center applied

One liner fix use text-align: center;

Maybe not a regression, but for I should have considered that since flexbox couldn't handle inline stuff very well.

Comment 2

[Fang Shih [:fang]]

After an offline discussion with Ray, and UX. We prefer to make the footer text shorter string " Preference "  when the width of the dropdown is shorter. And keep the text center aline in all languages. But still, prefer at lease keep English version in one line would be great. : )

Comment 3

[Ray Lin[:ralin]]

Per offline discussion with Mark, we concurred with the fact that it's hard to guarantee text in one-line even for English, in terms of system-level font-size, variable font-width, etc. I'd split the variants of string issue off to another bug, and go text-align: center first. Thanks.

Comment 4

[Ray Lin[:ralin]]

Attachment: Bug 1415836 - Make form autofill dropdown footer text centered.

Review commit: https://reviewboard.mozilla.org/r/199590/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/199590/

Comment 5

[Ray Lin[:ralin]]

Hey Luke, the patch is an one-liner quickfix, could you help me to review it? Thanks.

Comment 6

[Luke Chang [:lchang] (inactive)]

Comment on attachment 8928383 [details]
Bug 1415836 - Make form autofill dropdown footer text centered.

https://reviewboard.mozilla.org/r/199590/#review204710

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/28164096fde2
Make form autofill dropdown footer text centered. r=lchang

Comment 8

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/28164096fde2

Comment 9

[Ray Lin[:ralin]]

Comment on attachment 8928383 [details]
Bug 1415836 - Make form autofill dropdown footer text centered.

Approval Request Comment
[Feature/Bug causing the regression]: Form autofill dropdown footer
[User impact if declined]: terrible looking when words break into two lines (see screenshot)
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: yes, locally
[Needs manual test from QE? If yes, steps to reproduce]: no
[List of other uplifts needed for the feature/fix]: none
[Is the change risky?]: very low
[Why is the change risky/not risky?]: only one CSS rules added
[String changes made/needed]: none

Thanks :D

Comment 10

[Gerry Chang [:gchang]]

Hi Brindusa, could you help find someone to verify if this issue was fixed as expected on the latest Nightly build? Thanks!

Comment 11

[Gerry Chang [:gchang]]

Change NI to Gabi.

Comment 12

[Gabi Cheta [:Gabi] Release Desktop QA]

Verified as fixed with 59.0a1 20171116100106 on Windows 10x64, Ubuntu 14.4 and MacOS 10.12.6

Comment 13

[Gerry Chang [:gchang]]

Comment on attachment 8928383 [details]
Bug 1415836 - Make form autofill dropdown footer text centered.

Issue fixed and verified. Beta58+.

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/c78d02a2b591

Comment 15

[Gabi Cheta [:Gabi] Release Desktop QA]

Verified as fixed with 58.0b5 20171120142222 on Windows 10x64, MacOS 10.12.6 and Ubuntu 14.4