Closed Bug 1415850 Opened 2 years ago Closed 2 years ago

Clean up rule for hiding the urlbar's content while customizing

Categories

(Firefox :: Theme, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
Firefox 58
Tracking Status
firefox57 --- unaffected
firefox58 --- fixed

People

(Reporter: dao, Assigned: dao)

References

Details

Attachments

(1 file)

When I updated this rule:

https://hg.mozilla.org/integration/autoland/rev/f3cbb780f180#l1.12

... I missed that .searchbar-textbox isn't going to match there, and it doesn't need to as it's already covered by textbox.css.
Comment on attachment 8926814 [details]
Bug 1415850 - Clean up rule for hiding the urlbar's content while customizing.

https://reviewboard.mozilla.org/r/198066/#review203424

r=me if you want to land it this way since it's a simpler rule and the searchbox is already hidden via autocomplete.css.

But is it possible that we can remove the [customizing] selectors altogether and instead make this autocomplete selector more persmissive, so that it'll match both the URL bar and the search bar: https://hg.mozilla.org/integration/autoland/rev/f3cbb780f180#l8.12? If we removed some direct descendant selectors then perhaps we could simplify that down to one selector and have it match both cases.
Attachment #8926814 - Flags: review?(bgrinstead) → review+
I'll just land this as-is. Not sure how we'd modify those rules in autocomplete.css, but this can be a followup anyway.
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6d6700a8c0d2
Clean up rule for hiding the urlbar's content while customizing. r=bgrins
https://hg.mozilla.org/mozilla-central/rev/6d6700a8c0d2
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
You need to log in before you can comment on or make changes to this bug.