Closed
Bug 1415855
Opened 7 years ago
Closed 7 years ago
Remove unused mIconLoadingPrincipal field
Categories
(Firefox :: Tabbed Browser, enhancement, P3)
Firefox
Tabbed Browser
Tracking
()
RESOLVED
FIXED
Firefox 59
| Tracking | Status | |
|---|---|---|
| firefox59 | --- | fixed |
People
(Reporter: dao, Assigned: rohit4change, Mentored)
Details
(Keywords: good-first-bug)
Attachments
(1 file)
|
709 bytes,
patch
|
dao
:
review+
|
Details | Diff | Splinter Review |
This is unused and should be removed: http://searchfox.org/mozilla-central/rev/7e090b227f7a0ec44d4ded604823d48823158c51/browser/base/content/tabbrowser.xml#1015-1018
|
Assignee | |
Comment 1•7 years ago
|
||
Hi, I would like to work on it. But I am completely new to editing open source code. The above field is actually used elsewhere. Do we need to remove those too without affecting the rest?
Flags: needinfo?(dao+bmo)
|
Reporter | |
Comment 2•7 years ago
|
||
(In reply to rohit4change from comment #1) > Hi, > I would like to work on it. But I am completely new to editing open source > code. The above field is actually used elsewhere. Do we need to remove those > too without affecting the rest? These places are accessing the property on browser elements whereas this field exists on the parent tabbrowser element, there's no real connection between these two things.
Flags: needinfo?(dao+bmo)
|
|
Assignee | |
Comment 3•7 years ago
|
||
(In reply to Dão Gottwald [::dao] from comment #2) > (In reply to rohit4change from comment #1) > > Hi, > > I would like to work on it. But I am completely new to editing open source > > code. The above field is actually used elsewhere. Do we need to remove those > > too without affecting the rest? > > These places are accessing the property on browser elements whereas this > field exists on the parent tabbrowser element, there's no real connection > between these two things. Oh yes. Got it. So we just need to remove that field. Can I do it?
|
|
Reporter | |
Comment 4•7 years ago
|
||
(In reply to QuanTakeuchi from comment #3) > Oh yes. Got it. So we just need to remove that field. Can I do it? Sure!
Assignee: nobody → rohit4change
|
|
Assignee | |
Comment 5•7 years ago
|
||
Attachment #8927569 -
Flags: review?(dao+bmo)
|
|
Reporter | |
Comment 6•7 years ago
|
||
Comment on attachment 8927569 [details] [diff] [review] tabbrowser.patch Looks good, thanks!
Attachment #8927569 -
Flags: review?(dao+bmo) → review+
|
|
Reporter | |
Updated•7 years ago
|
Keywords: checkin-needed
Pushed by dgottwald@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/e271649a3e03 Remove unused mIconLoadingPrincipal field. r=dao
Keywords: checkin-needed
|
||
Comment 8•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/e271649a3e03
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox59:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
You need to log in
before you can comment on or make changes to this bug.
Description
•