Remove unused mIconLoadingPrincipal field

RESOLVED FIXED in Firefox 59

Status

()

enhancement
P3
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: dao, Assigned: rohit4change, Mentored)

Tracking

({good-first-bug})

Trunk
Firefox 59
Points:
---

Firefox Tracking Flags

(firefox59 fixed)

Details

Attachments

(1 attachment)

Assignee

Comment 1

2 years ago
Hi, 
I would like to work on it. But I am completely new to editing open source code. The above field is actually used elsewhere. Do we need to remove those too without affecting the rest?
Flags: needinfo?(dao+bmo)
Reporter

Comment 2

2 years ago
(In reply to rohit4change from comment #1)
> Hi, 
> I would like to work on it. But I am completely new to editing open source
> code. The above field is actually used elsewhere. Do we need to remove those
> too without affecting the rest?

These places are accessing the property on browser elements whereas this field exists on the parent tabbrowser element, there's no real connection between these two things.
Flags: needinfo?(dao+bmo)
Assignee

Comment 3

2 years ago
(In reply to Dão Gottwald [::dao] from comment #2)
> (In reply to rohit4change from comment #1)
> > Hi, 
> > I would like to work on it. But I am completely new to editing open source
> > code. The above field is actually used elsewhere. Do we need to remove those
> > too without affecting the rest?
> 
> These places are accessing the property on browser elements whereas this
> field exists on the parent tabbrowser element, there's no real connection
> between these two things.

Oh yes. Got it. So we just need to remove that field. Can I do it?
Reporter

Comment 4

2 years ago
(In reply to QuanTakeuchi from comment #3)
> Oh yes. Got it. So we just need to remove that field. Can I do it?

Sure!
Assignee: nobody → rohit4change
Assignee

Comment 5

2 years ago
Attachment #8927569 - Flags: review?(dao+bmo)
Reporter

Comment 6

2 years ago
Comment on attachment 8927569 [details] [diff] [review]
tabbrowser.patch

Looks good, thanks!
Attachment #8927569 - Flags: review?(dao+bmo) → review+
Reporter

Updated

2 years ago
Keywords: checkin-needed

Comment 7

2 years ago
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e271649a3e03
Remove unused mIconLoadingPrincipal field. r=dao
Keywords: checkin-needed

Comment 8

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/e271649a3e03
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
You need to log in before you can comment on or make changes to this bug.