Closed
Bug 1415880
Opened 7 years ago
Closed 7 years ago
Remove obsolete mIsValid flag from gfxFontEntry
Categories
(Core :: Graphics: Text, enhancement)
Core
Graphics: Text
Tracking
()
RESOLVED
FIXED
mozilla58
| Tracking | Status | |
|---|---|---|
| firefox58 | --- | fixed |
People
(Reporter: jfkthame, Assigned: jfkthame)
Details
Attachments
(1 file)
|
3.06 KB,
patch
|
jrmuizel
:
review+
|
Details | Diff | Splinter Review |
This is just a bit (literally) of cleanup: we have a bool mIsValid flag in gfxFontEntry, but nobody has cared about it for years; it's initialized to true by the constructors, and then never touched again. So let's get rid of it. (Not to be confused with the mIsValid flag in gfxFont, which does get used in various places to mark fonts that for some reason we can't actually use.)
|
Assignee | |
Comment 1•7 years ago
|
||
Attachment #8926846 -
Flags: review?(jmuizelaar)
|
||
Updated•7 years ago
|
Attachment #8926846 -
Flags: review?(jmuizelaar) → review+
Pushed by jkew@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/a48c10a1e064 Remove the obsolete mIsValid flag from gfxFontEntry, as nothing depends on it any more. r=jrmuizel
|
||
Comment 3•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/a48c10a1e064
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox58:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in
before you can comment on or make changes to this bug.
Description
•