1415919 - JSON viewer should not scroll to the top of the row if it's too tall

Status: RESOLVED FIXED

(DevTools :: JSON Viewer, defect)

Description

[Oriol Brufau [:Oriol]]

1. Open the console and enter

    location.href = encodeURI("data:application/json," + JSON.stringify(["Lorem ipsum. ".repeat(1500)]))

2. There should be a vertical scrollbar (otherwise shrink the Firefox window)

3. Scroll down

4. Select some text contents

Result: JSON Viewer scrolls to the top of the cell when you release the mouse. The text you selected may no longer be visible.

Comment 1

[Oriol Brufau [:Oriol]]

Attachment: Bug 1415919 - Improve how JSON Viewer scrolls selected row into view.

Review commit: https://reviewboard.mozilla.org/r/198202/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/198202/

Comment 2

[Oriol Brufau [:Oriol]]

With this the behavior seems more reasonable, scrollIntoView should have some option to do this.

Comment 3

[Oriol Brufau [:Oriol]]

Comment on attachment 8926950 [details]
Bug 1415919 - Improve how JSON Viewer scrolls selected row into view.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/198202/diff/1-2/

Comment 4

[Oriol Brufau [:Oriol]]

Comment on attachment 8926950 [details]
Bug 1415919 - Improve how JSON Viewer scrolls selected row into view.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/198202/diff/2-3/

Comment 5

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Comment on attachment 8926950 [details]
Bug 1415919 - Improve how JSON Viewer scrolls selected row into view.

https://reviewboard.mozilla.org/r/198202/#review203722

Looks reasonable, good work as usual Oriol!
R+ assuming Try is green

Honza

Comment 6

[Oriol Brufau [:Oriol]]

The Try failures were due to bug 1416070.

Comment 7

[Oriol Brufau [:Oriol]]

Comment on attachment 8926950 [details]
Bug 1415919 - Improve how JSON Viewer scrolls selected row into view.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/198202/diff/3-4/

Comment 8

[Oriol Brufau [:Oriol]]

I did a trivial simplification of scrollContainer.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/efbc0ed871b5
Improve how JSON Viewer scrolls selected row into view. r=Honza

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/efbc0ed871b5