1415952 - TPS should test syncing webextensions in it's addon sync tests

Status: RESOLVED FIXED

(Firefox :: Sync, enhancement, P2)

Description

[Thom Chiovoloni [:tcsc] (ex-moco)]

Right now we test restartless and non-restartless legacy extensions in TPS. Neither of these tests are particularly valuable anymore. We should replace them with tests that ensure that webextensions are properly synced, since we currently have no coverage for that (I'd assume it works if the other works, since it should be easier?).

Comment 1

[Thom Chiovoloni [:tcsc] (ex-moco)]

Non-restartless addons are dead now, which causes TPS to fail in stage (someday it will pass...)

Instead of disabling the test, I'm just going to replace it a webextension one (there's one https://searchfox.org/mozilla-central/source/testing/mozbase/mozprofile/tests/addons that seems easy to use).

This is more or less trivial so patch incoming.

Comment 2

[Thom Chiovoloni [:tcsc] (ex-moco)]

Attachment: Bug 1415952 - Remove nonrestartless addon tests from TPS, replace with webextension

Review commit: https://reviewboard.mozilla.org/r/237320/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/237320/

Comment 3

[Mark Hammond [:markh] [:mhammond]]

Comment on attachment 8968627 [details]
Bug 1415952 - Remove nonrestartless addon tests from TPS, replace with webextension

https://reviewboard.mozilla.org/r/237320/#review243200

Awesome, thanks

::: services/sync/tests/tps/addons/api/[e-mail]:14
(Diff revision 1)
> +        "version": "1.0",
> +        "files": [
> +          {
> +            "platform": "all",
> +            "size": 3412,
> +            "url": "http://127.0.0.1:4567/addons/apply-css.xpi"

should/can we rename this .xpi to something a little more accurate?

Comment 4

[Thom Chiovoloni [:tcsc] (ex-moco)]

Comment on attachment 8968627 [details]
Bug 1415952 - Remove nonrestartless addon tests from TPS, replace with webextension

https://reviewboard.mozilla.org/r/237320/#review243200

> should/can we rename this .xpi to something a little more accurate?

It wouldn't be obvious it's the same as the apply-css webextension we have elsewhere, but maybe that doesn't matter.

Comment 5

[Thom Chiovoloni [:tcsc] (ex-moco)]

Comment on attachment 8968627 [details]
Bug 1415952 - Remove nonrestartless addon tests from TPS, replace with webextension

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/237320/diff/1-2/

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/aff1fec98317
Remove nonrestartless addon tests from TPS, replace with webextension r=markh

Comment 7

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/aff1fec98317