TPS should test syncing webextensions in it's addon sync tests

RESOLVED FIXED in Firefox 61

Status

()

enhancement
P2
normal
RESOLVED FIXED
2 years ago
Last year

People

(Reporter: tcsc, Assigned: tcsc)

Tracking

unspecified
Firefox 61
Points:
---

Firefox Tracking Flags

(firefox61 fixed)

Details

Attachments

(1 attachment)

Right now we test restartless and non-restartless legacy extensions in TPS. Neither of these tests are particularly valuable anymore. We should replace them with tests that ensure that webextensions are properly synced, since we currently have no coverage for that (I'd assume it works if the other works, since it should be easier?).
Priority: -- → P3
Non-restartless addons are dead now, which causes TPS to fail in stage (someday it will pass...)

Instead of disabling the test, I'm just going to replace it a webextension one (there's one https://searchfox.org/mozilla-central/source/testing/mozbase/mozprofile/tests/addons that seems easy to use).

This is more or less trivial so patch incoming.
Assignee: nobody → tchiovoloni
Priority: P3 → P2
Comment on attachment 8968627 [details]
Bug 1415952 - Remove nonrestartless addon tests from TPS, replace with webextension

https://reviewboard.mozilla.org/r/237320/#review243200

Awesome, thanks

::: services/sync/tests/tps/addons/api/test-webext@quality.mozilla.org.json:14
(Diff revision 1)
> +        "version": "1.0",
> +        "files": [
> +          {
> +            "platform": "all",
> +            "size": 3412,
> +            "url": "http://127.0.0.1:4567/addons/apply-css.xpi"

should/can we rename this .xpi to something a little more accurate?
Attachment #8968627 - Flags: review?(markh) → review+
Comment on attachment 8968627 [details]
Bug 1415952 - Remove nonrestartless addon tests from TPS, replace with webextension

https://reviewboard.mozilla.org/r/237320/#review243200

> should/can we rename this .xpi to something a little more accurate?

It wouldn't be obvious it's the same as the apply-css webextension we have elsewhere, but maybe that doesn't matter.
Pushed by tchiovoloni@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/aff1fec98317
Remove nonrestartless addon tests from TPS, replace with webextension r=markh
https://hg.mozilla.org/mozilla-central/rev/aff1fec98317
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
You need to log in before you can comment on or make changes to this bug.