Bugzilla's buttons box-shadow falls back.

RESOLVED FIXED in mozilla58

Status

()

enhancement
P1
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: jrmuizel, Assigned: ethlin)

Tracking

(Blocks 2 bugs)

unspecified
mozilla58
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox57 unaffected, firefox58 unaffected)

Details

(Whiteboard: [wr-mvp])

Attachments

(1 attachment)

Here's the shadow:  0 1px 0 0 rgba(0,0,0,0.2),inset 0 -1px 0 0 rgba(0,0,0,0.3);
Setting layers.advanced.boxshadow-outer-layers to true fixes it. I think we need to go through the code and remove lots of ShouldUseAdvancedLayer checks, now that we have layers-free.
Or actually I'm not sure what the intended use of ShouldUseAdvancedLayer is in today's world.
Whiteboard: [wr-mvp] [triage]
(In reply to Markus Stange [:mstange] from comment #2)
> Or actually I'm not sure what the intended use of ShouldUseAdvancedLayer is
> in today's world.

I'm not sure neither. But for most of items, I think we shouldn't call ShouldUseAdvancedLayer anymore. For this bug, it's because we still check that in nsDisplayButtonBoxShadowOuter.
Assignee: nobody → ethlin
Comment on attachment 8927195 [details]
Bug 1415989 - Do not use 'ShouldUseAdvancedLayer' for button type display items.

https://reviewboard.mozilla.org/r/198466/#review203766

That's a nice looking patch
Attachment #8927195 - Flags: review?(jmuizelaar) → review+
Status: NEW → ASSIGNED
Priority: P2 → P1
Whiteboard: [wr-mvp] [triage] → [wr-mvp]
Pushed by ethlin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/75381304ee9a
Do not use 'ShouldUseAdvancedLayer' for button type display items. r=jrmuizel
https://hg.mozilla.org/mozilla-central/rev/75381304ee9a
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in before you can comment on or make changes to this bug.