1415989 - Bugzilla's buttons box-shadow falls back.

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement, P1)

Description

[Jeff Muizelaar [:jrmuizel]]

Here's the shadow:  0 1px 0 0 rgba(0,0,0,0.2),inset 0 -1px 0 0 rgba(0,0,0,0.3);

Comment 1

[Markus Stange [:mstange]]

Setting layers.advanced.boxshadow-outer-layers to true fixes it. I think we need to go through the code and remove lots of ShouldUseAdvancedLayer checks, now that we have layers-free.

Comment 2

[Markus Stange [:mstange]]

Or actually I'm not sure what the intended use of ShouldUseAdvancedLayer is in today's world.

Comment 3

[Ethan Lin[:ethlin]]

(In reply to Markus Stange [:mstange] from comment #2)
> Or actually I'm not sure what the intended use of ShouldUseAdvancedLayer is
> in today's world.

I'm not sure neither. But for most of items, I think we shouldn't call ShouldUseAdvancedLayer anymore. For this bug, it's because we still check that in nsDisplayButtonBoxShadowOuter.

Comment 4

[Ethan Lin[:ethlin]]

Attachment: Bug 1415989 - Do not use 'ShouldUseAdvancedLayer' for button type display items.

Review commit: https://reviewboard.mozilla.org/r/198466/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/198466/

Comment 5

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8927195 [details]
Bug 1415989 - Do not use 'ShouldUseAdvancedLayer' for button type display items.

https://reviewboard.mozilla.org/r/198466/#review203766

That's a nice looking patch

Comment 6

[Ethan Lin[:ethlin]]

Comment on attachment 8927195 [details]
Bug 1415989 - Do not use 'ShouldUseAdvancedLayer' for button type display items.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/198466/diff/1-2/

Comment 7

[Ethan Lin[:ethlin]]

Comment on attachment 8927195 [details]
Bug 1415989 - Do not use 'ShouldUseAdvancedLayer' for button type display items.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/198466/diff/2-3/

Comment 8

[Ethan Lin[:ethlin]]

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=397d5daa27f93f39b3dd14488cae4e18a4b182b5&selectedJob=143934450

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/75381304ee9a
Do not use 'ShouldUseAdvancedLayer' for button type display items. r=jrmuizel

Comment 10

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/75381304ee9a