Closed Bug 1416008 Opened 6 years ago Closed 6 years ago

Support downloading grcov for Windows

Categories

(Testing :: Code Coverage, enhancement)

Product:
Testing
Component:
Code Coverage
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(firefox58 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla58
Tracking Flags:
Tracking Status
firefox58 --- fixed

People

(Reporter: marco, Assigned: marco)

References

Details

Attachments

(2 files)

Patch
3.53 KB, patch
jmaher
: review+
Details | Diff | Splinter Review
Support packaging coverage artifacts on Windows
6.67 KB, patch
jmaher
: review+
Details | Diff | Splinter Review 
      No description provided.
Attached patch Patch — — Splinter Review 

        Attachment #8927327 -
        Flags: review?(jmaher)

    
    

    
  
Comment on attachment 8927327 [details] [diff] [review]
Patch

Review of attachment 8927327 [details] [diff] [review]:
-----------------------------------------------------------------

this looks good!

        Attachment #8927327 -
        Flags: review?(jmaher) → review+

    
    

    
  


  

        Attachment #8927327 -
        Attachment is obsolete: true

        Attachment #8927371 -
        Flags: review?(jmaher)

        Attachment #8927371 -
        Flags: review?(jmaher) → review+

    
    

    
  
Pushed by mcastelluccio@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/257e004c31f2
Support downloading grcov for Windows. r=jmaher
https://hg.mozilla.org/integration/mozilla-inbound/rev/a04bb99cdd47
Support packaging code coverage files and running grcov on Windows. r=jmaher

    
    

    
  
Note there is an error when running grcov (about a missing DLL, I don't know which one as its name is not mentioned in the logs).
I probably just need to rebuild grcov with different settings, so no additional code changes should be needed on mozilla-central (except for manifest update).

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/257e004c31f2
https://hg.mozilla.org/mozilla-central/rev/a04bb99cdd47
Status: ASSIGNED → RESOLVED
Closed: 6 years ago

          status-firefox58:
          --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla58

    
  

        Attachment #8927327 -
        Attachment is obsolete: false

          You need to log in
          before you can comment on or make changes to this bug.