Closed
Bug 1416008
Opened 7 years ago
Closed 7 years ago
Support downloading grcov for Windows
Categories
(Testing :: Code Coverage, enhancement)
Testing
Code Coverage
Tracking
(firefox58 fixed)
RESOLVED
FIXED
mozilla58
| Tracking | Status | |
|---|---|---|
| firefox58 | --- | fixed |
People
(Reporter: marco, Assigned: marco)
References
Details
Attachments
(2 files)
|
3.53 KB,
patch
|
jmaher
:
review+
|
Details | Diff | Splinter Review |
|
6.67 KB,
patch
|
jmaher
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•7 years ago
|
||
Attachment #8927327 -
Flags: review?(jmaher)
|
||
Comment 2•7 years ago
|
||
Comment on attachment 8927327 [details] [diff] [review] Patch Review of attachment 8927327 [details] [diff] [review]: ----------------------------------------------------------------- this looks good!
Attachment #8927327 -
Flags: review?(jmaher) → review+
|
|
Assignee | |
Comment 3•7 years ago
|
||
Attachment #8927327 -
Attachment is obsolete: true
Attachment #8927371 -
Flags: review?(jmaher)
|
|
||
Updated•7 years ago
|
Attachment #8927371 -
Flags: review?(jmaher) → review+
Pushed by mcastelluccio@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/257e004c31f2 Support downloading grcov for Windows. r=jmaher https://hg.mozilla.org/integration/mozilla-inbound/rev/a04bb99cdd47 Support packaging code coverage files and running grcov on Windows. r=jmaher
|
|
Assignee | |
Comment 5•7 years ago
|
||
Note there is an error when running grcov (about a missing DLL, I don't know which one as its name is not mentioned in the logs). I probably just need to rebuild grcov with different settings, so no additional code changes should be needed on mozilla-central (except for manifest update).
|
||
Comment 6•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/257e004c31f2 https://hg.mozilla.org/mozilla-central/rev/a04bb99cdd47
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox58:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
|
|
Assignee | |
Updated•7 years ago
|
Attachment #8927327 -
Attachment is obsolete: false
You need to log in
before you can comment on or make changes to this bug.
Description
•