1416012 - Code in LogicalRect::IsEmpty is fishy

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Boris Zbarsky [:bzbarsky]]

After bug 1389152 it's doing:

    return mISize <= 0 || mBSize << 0;

which leads to these compiler warnings:

 0:52.16 ../../dist/include/mozilla/WritingModes.h: In member function ‘bool mozilla::LogicalRect::IsEmpty() const’:
 0:52.16 ../../dist/include/mozilla/WritingModes.h:1699:34: warning: ‘<<’ in boolean context, did you mean ‘<’ ? [-Wint-in-bool-context]
 0:52.16      return mISize <= 0 || mBSize << 0;
 0:52.16                            ~~~~~~~^~~~

I think I agree with the compiler.  This will return true any time mBSize is nonzero, afaict, which seems highly dubious.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Maybe the tree is green because this method is unused?

Comment 2

[Milan Sreckovic [:milan] (needinfo for best results)]

Attachment: Fixing a typo where << was used instead of <= (in a currently unused function LogicalRect::IsEmpty)

Comment 3

[Milan Sreckovic [:milan] (needinfo for best results)]

(In reply to Boris Zbarsky [:bz] (no decent commit message means r-) from comment #0)
> After bug 1389152 it's doing:
> 
>     return mISize <= 0 || mBSize << 0;

Yikes.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8927349 [details] [diff] [review]
Fixing a typo where << was used instead of <= (in a currently unused function LogicalRect::IsEmpty)

r=me

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/56d0ff94578a
Fix a typo where << was used instead of <= (in a currently unused function LogicalRect::IsEmpty). r=bz

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/56d0ff94578a