Without any one-click search engines, awesomebar opens unseen Search preferences gear

RESOLVED FIXED in Firefox 59

Status

()

P1
normal
RESOLVED FIXED
a year ago
10 months ago

People

(Reporter: ashish, Assigned: mak)

Tracking

58 Branch
Firefox 59
Points:
---

Firefox Tracking Flags

(firefox57 wontfix, firefox58 wontfix, firefox59 fixed)

Details

(Whiteboard: [fxsearch])

Attachments

(2 attachments)

(Reporter)

Description

a year ago
Created attachment 8927065 [details]
invisible-search-preferences.mov

This has caught me unawares a few times in the past, but I was never able to identify/repro the issue. I've also attached a screencast, hopefully that helps.

STR:
1. In about:preferences#search, disable all one-click search engines. This should remove the search engines, and the pref gear from the bottom of the awesome bar. Search suggestions can be left turned on.
2. Open a new tab, type a couple of characters- ex: "moz", wait for suggestions to populate. Awesome bar focus should be on "moz - Search with Yahoo"
3. Hit the up arrow on the keyboard
4. Hit enter

Expected results:
Focus should move the last suggestion, or to the address bar.

Actual results:
about:preferences#search opens


Tested on a fresh profile of Nightly 58.0a Build ID 20171109100107, macOS 10.12.6.
(Assignee)

Comment 1

a year ago
That looks annoying, setting as P1, we'll try to fix it for 58.
Priority: -- → P1
Whiteboard: [fxsearch]
I wonder if fixing bug 1369012 could fix this one as well.
status-firefox57: --- → wontfix
(Assignee)

Updated

10 months ago
Assignee: nobody → mak77
Status: NEW → ASSIGNED
(Assignee)

Updated

10 months ago
Blocks: 1369012
Comment hidden (mozreview-request)

Comment 4

10 months ago
mozreview-review
Comment on attachment 8941906 [details]
Bug 1416041 - Collapse one-offs buttons if only the current engine is active and don't select search settings when collapsed.

https://reviewboard.mozilla.org/r/212124/#review218156

Looks good to me, thanks!
Attachment #8941906 - Flags: review?(florian) → review+

Comment 5

10 months ago
Pushed by mak77@bonardo.net:
https://hg.mozilla.org/integration/autoland/rev/69408f067a9c
Collapse one-offs buttons if only the current engine is active and don't select search settings when collapsed. r=florian

Comment 6

10 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/69408f067a9c
Status: ASSIGNED → RESOLVED
Last Resolved: 10 months ago
status-firefox59: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
not a new regression in 58, and we're at RC week => wontfix
status-firefox58: affected → wontfix
You need to log in before you can comment on or make changes to this bug.