1416041 - Without any one-click search engines, awesomebar opens unseen Search preferences gear

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect, P1)

Description

[Ashish Vijayaram [:ashish]]

Attachment: invisible-search-preferences.mov

This has caught me unawares a few times in the past, but I was never able to identify/repro the issue. I've also attached a screencast, hopefully that helps.

STR:
1. In about:preferences#search, disable all one-click search engines. This should remove the search engines, and the pref gear from the bottom of the awesome bar. Search suggestions can be left turned on.
2. Open a new tab, type a couple of characters- ex: "moz", wait for suggestions to populate. Awesome bar focus should be on "moz - Search with Yahoo"
3. Hit the up arrow on the keyboard
4. Hit enter

Expected results:
Focus should move the last suggestion, or to the address bar.

Actual results:
about:preferences#search opens


Tested on a fresh profile of Nightly 58.0a Build ID 20171109100107, macOS 10.12.6.

Comment 1

[Marco Bonardo [:mak]]

That looks annoying, setting as P1, we'll try to fix it for 58.

Comment 2

[Panos Astithas (he/him) [:past] (please ni?)]

I wonder if fixing bug 1369012 could fix this one as well.

Comment 3

[Marco Bonardo [:mak]]

Attachment: Bug 1416041 - Collapse one-offs buttons if only the current engine is active and don't select search settings when collapsed.

Review commit: https://reviewboard.mozilla.org/r/212124/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/212124/

Comment 4

[Florian Quèze [:florian]]

Comment on attachment 8941906 [details]
Bug 1416041 - Collapse one-offs buttons if only the current engine is active and don't select search settings when collapsed.

https://reviewboard.mozilla.org/r/212124/#review218156

Looks good to me, thanks!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/69408f067a9c
Collapse one-offs buttons if only the current engine is active and don't select search settings when collapsed. r=florian

Comment 6

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/69408f067a9c

Comment 7

[Julien Cristau [:jcristau]]

not a new regression in 58, and we're at RC week => wontfix