Closed
Bug 1416048
Opened 8 years ago
Closed 8 years ago
The DNS TTL entries use 32 bit data fields, so use 32 bit storage for them!
Categories
(Core :: Networking: DNS, enhancement, P1)
Core
Networking: DNS
Tracking
()
RESOLVED
FIXED
mozilla58
| Tracking | Status | |
|---|---|---|
| firefox58 | --- | fixed |
People
(Reporter: daniel, Assigned: daniel)
Details
(Whiteboard: [necko-triaged])
Attachments
(1 file)
|
2.01 KB,
patch
|
valentin
:
review+
|
Details | Diff | Splinter Review |
The (Windows-specific) resolver logic that extracts the TTL from DNS for names (enabled in bug 1167552) uses an uint16_t to store the numerical value, while the underlying DNS field for TTL is actually an unsigned 32 bit value. The internal value thus get truncated for values larger than 65535. This being in seconds, that value equals 18.2 hours.
This patch changes the data field for storage to use the full 32 bit size.
Attachment #8927078 -
Flags: review?(valentin.gosu)
Assignee: nobody → daniel
Priority: -- → P1
Whiteboard: [necko-triaged]
|
||
Updated•8 years ago
|
Attachment #8927078 -
Flags: review?(valentin.gosu) → review+
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e118b79b153e
Use uint32_t for DNS TTL data. r=valentin
Keywords: checkin-needed
|
||
Comment 4•8 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox58:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in
before you can comment on or make changes to this bug.
Description
•